(PUP-11767) add Style/ClassCheck and ClassEqualityComparison checks

Author: tvpartytonight

.rubocop.yml

@@ -208,3 +208,9 @@ Style/CaseEquality:
 
 Style/CaseLikeIf:
   Enabled: true
+
+Style/ClassCheck:
+  Enabled: true
+
+Style/ClassEqualityComparison:
+  Enabled: true

lib/puppet/module_tool.rb

@@ -48,7 +48,7 @@ def self.username_and_modname_from(full_module_name)
     # @return [Pathname, nil] the root path of the module directory or nil if
     #   we cannot find one
     def self.find_module_root(path)
-      path = Pathname.new(path) if path.class == String
+      path = Pathname.new(path) if path.instance_of?(String)
 
       path.expand_path.ascend do |p|
         return p if is_module_root?(p)
@@ -63,7 +63,7 @@ def self.find_module_root(path)
     # @param path [Pathname, String] path to analyse
     # @return [Boolean] true if the path is a module root, false otherwise
     def self.is_module_root?(path)
-      path = Pathname.new(path) if path.class == String
+      path = Pathname.new(path) if path.instance_of?(String)
 
       FileTest.file?(path + 'metadata.json')
     end

lib/puppet/parser/compiler.rb

@@ -240,7 +240,7 @@ def evaluate_classes(classes, scope, lazy_evaluate = true)
     class_parameters = nil
     # if we are a param class, save the classes hash
     # and transform classes to be the keys
-    if classes.class == Hash
+    if classes.instance_of?(Hash)
       class_parameters = classes
       classes = classes.keys
     end
@@ -543,7 +543,7 @@ def initvars
     @resources = []
 
     # Make sure any external node classes are in our class list
-    if @node.classes.class == Hash
+    if @node.classes.instance_of?(Hash)
       @catalog.add_class(*@node.classes.keys)
     else
       @catalog.add_class(*@node.classes)

lib/puppet/pops/evaluator/access_operator.rb

@@ -378,7 +378,7 @@ def access_PNotUndefType(o, scope, keys)
       when String
         type = Types::TypeFactory.string(type)
       when Types::PAnyType
-        type = nil if type.class == Types::PAnyType
+        type = nil if type.instance_of?(Types::PAnyType)
       else
         fail(Issues::BAD_NOT_UNDEF_SLICE_TYPE, @semantic.keys[0], { :base_type => 'NotUndef-Type', :actual => type.class })
       end

lib/puppet/pops/evaluator/deferred_resolver.rb

@@ -117,7 +117,7 @@ def mark_sensitive_parameters(r, k)
   private :mark_sensitive_parameters
 
   def resolve(x)
-    if x.class == @deferred_class
+    if x.instance_of?(@deferred_class)
       resolve_future(x)
     elsif x.is_a?(Array)
       x.map { |v| resolve(v) }

lib/puppet/pops/types/p_binary_type.rb

@@ -225,7 +225,7 @@ def from_hash(hash)
   protected
 
   def _assignable?(o, guard)
-    o.class == self.class
+    o.instance_of?(self.class)
   end
 end
 end

lib/puppet/pops/types/p_object_type.rb

@@ -170,7 +170,7 @@ def assert_override(parent_members)
     # @raises [Puppet::ParseError] if the assertion fails
     # @api private
     def assert_can_be_overridden(member)
-      unless self.class == member.class
+      unless self.instance_of?(member.class)
         raise Puppet::ParseError, _("%{member} attempts to override %{label}") % { member: member.label, label: label }
       end
       if @final && !(constant? && member.constant?)

lib/puppet/pops/types/p_sem_ver_type.rb

@@ -119,7 +119,7 @@ def to_array(component)
   protected
 
   def _assignable?(o, guard)
-    return false unless o.class == self.class
+    return false unless o.instance_of?(self.class)
     return true if @ranges.empty?
     return false if o.ranges.empty?
 

lib/puppet/pops/types/p_sensitive_type.rb

@@ -72,7 +72,7 @@ def from_sensitive(value)
   private
 
   def _assignable?(o, guard)
-    self.class == o.class && @type.assignable?(o.type, guard)
+    self.instance_of?(o.class) && @type.assignable?(o.type, guard)
   end
 
   DEFAULT = PSensitiveType.new

lib/puppet/pops/types/p_timespan_type.rb

@@ -17,7 +17,7 @@ def initialize(from, to = nil)
     # @return [Boolean] `true` if this range intersects with the other range
     # @api public
     def intersect?(o)
-      self.class == o.class && !(@to < o.numeric_from || o.numeric_to < @from)
+      self.instance_of?(o.class) && !(@to < o.numeric_from || o.numeric_to < @from)
     end
 
     # Returns the lower bound of the numeric range or `nil` if no lower bound is set.
@@ -94,7 +94,7 @@ def merge(o)
     end
 
     def _assignable?(o, guard)
-      self.class == o.class && numeric_from <= o.numeric_from && numeric_to >= o.numeric_to
+      self.instance_of?(o.class) && numeric_from <= o.numeric_from && numeric_to >= o.numeric_to
     end
   end