Skip to content

Commit 2e97615

Browse files
committed
Drop commits check
Now that GH issues are the source of truth, we can drop the commits check. [skip ci] (cherry picked from commit f538a11)
1 parent e5ee2c7 commit 2e97615

File tree

2 files changed

+0
-28
lines changed

2 files changed

+0
-28
lines changed

.github/workflows/checks.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ jobs:
1717
matrix:
1818
cfg:
1919
- {check: rubocop, os: ubuntu-latest, ruby: '2.7'}
20-
- {check: commits, os: ubuntu-latest, ruby: '2.7'}
2120
- {check: warnings, os: ubuntu-latest, ruby: '2.7'}
2221

2322
runs-on: ${{ matrix.cfg.os }}

Rakefile

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -58,33 +58,6 @@ task(:rubocop) do
5858
raise "RuboCop detected offenses" if exit_code != 0
5959
end
6060

61-
desc "verify that commit messages match CONTRIBUTING.md requirements"
62-
task(:commits) do
63-
# This rake task looks at the summary from every commit from this branch not
64-
# in the branch targeted for a PR.
65-
commit_range = 'HEAD^..HEAD'
66-
puts "Checking commits #{commit_range}"
67-
%x{git log --no-merges --pretty=%s #{commit_range}}.each_line do |commit_summary|
68-
# This regex tests for the currently supported commit summary tokens: maint, doc, packaging, or pup-<number>.
69-
# The exception tries to explain it in more full.
70-
if /^\((maint|doc|docs|packaging|l10n|pup-\d+)\)|revert/i.match(commit_summary).nil?
71-
raise "\n\n\n\tThis commit summary didn't match CONTRIBUTING.md guidelines:\n" \
72-
"\n\t\t#{commit_summary}\n" \
73-
"\tThe commit summary (i.e. the first line of the commit message) should start with one of:\n" \
74-
"\t\t(PUP-<digits>) # this is most common and should be a ticket at tickets.puppet.com\n" \
75-
"\t\t(docs)\n" \
76-
"\t\t(docs)(DOCUMENT-<digits>)\n" \
77-
"\t\t(maint)\n" \
78-
"\t\t(packaging)\n" \
79-
"\t\t(L10n)\n" \
80-
"\n\tThis test for the commit summary is case-insensitive.\n\n\n"
81-
else
82-
puts "#{commit_summary}"
83-
end
84-
puts "...passed"
85-
end
86-
end
87-
8861
desc "verify that changed files are clean of Ruby warnings"
8962
task(:warnings) do
9063
# This rake task looks at all files modified in this branch.

0 commit comments

Comments
 (0)