Merge pull request #9008 from smortex/fqdn_rand_legacy_facts-7

(PUP-11752) Fix usage of legacy fact in fqdn_rand

Author: AriaXLi

lib/puppet/parser/functions/fqdn_rand.rb

@@ -23,7 +23,7 @@
     initial_seed = args.shift
     downcase = !!args.shift
 
-    fqdn = self['::fqdn']
+    fqdn = self['facts'].dig('networking', 'fqdn')
     fqdn = fqdn.downcase if downcase
 
     # Puppet 5.4's fqdn_rand function produces a different value than earlier versions

spec/unit/parser/functions/fqdn_rand_spec.rb

@@ -80,7 +80,7 @@ def fqdn_rand(max, args = {})
     extra = args[:extra_identifier] || []
 
     scope = create_test_scope_for_node('localhost')
-    scope.compiler.topscope['fqdn'] = host.freeze
+    scope.set_facts({ 'networking' => { 'fqdn' => host }})
 
     scope.function_fqdn_rand([max] + extra)
   end