Disable Rubocop Layout cops in package providers

This commit targets portions of package providers to disable Rubocop's
Layout cops. These portions of the code mix confine statements, control
expressions, and exception handling, which cause Rubocop to act
unexpectedly and flag false positives.

Author: mhashizume

.rubocop.yml

@@ -23,22 +23,9 @@ Layout:
   Exclude:
     - 'lib/puppet/defaults.rb'
 
-# The confine statements in package providers unexpectedly affect this cop.
-Layout/BeginEndAlignment:
-  Enabled: true
-  Exclude:
-    - 'lib/puppet/provider/package/*.rb'
-
-Layout/ElseAlignment:
-  Enabled: true
-  Exclude:
-    - 'lib/puppet/provider/package/*.rb'
-
 # We don't mind when module and class keywords are aligned.
 Layout/IndentationWidth:
   AllowedPatterns: ['^\s*module']
-  Exclude:
-    - 'lib/puppet/provider/package/*.rb'
 
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true

lib/puppet/provider/package/apt.rb

@@ -78,13 +78,16 @@ def flush
   # Debian boxes, and the only thing that differs is that it can
   # install packages from remote sites.
 
+  # Double negation confuses Rubocop's Layout cops
+  # rubocop:disable Layout
   def checkforcdrom
     have_cdrom = begin
                    !!(File.read("/etc/apt/sources.list") =~ /^[^#]*cdrom:/)
                  rescue
                    # This is basically pathological...
                    false
                  end
+  # rubocop:enable Layout
 
     if have_cdrom and @resource[:allowcdrom] != :true
       raise Puppet::Error,

lib/puppet/provider/package/aptrpm.rb

@@ -12,6 +12,9 @@
   commands :aptcache => "apt-cache"
   commands :rpm => "rpm"
 
+  # Mixing confine statements, control expressions, and exception handling
+  # confuses Rubocop's Layout cops, so we disable them entirely.
+  # rubocop:disable Layout
   if command('rpm')
     confine :true => begin
       rpm('-ql', 'rpm')
@@ -21,6 +24,7 @@
         true
       end
   end
+  # rubocop:enable Layout
 
   # Install a package using 'apt-get'.  This function needs to support
   # installing a specific version.

lib/puppet/provider/package/dnf.rb

@@ -20,6 +20,10 @@
   # never try to use RPM on a machine without it. We think this
   # has probably become obsolete with the way `commands` work, so
   # we should investigate removing it at some point.
+  #
+  # Mixing confine statements, control expressions, and exception handling
+  # confuses Rubocop's Layout cops, so we disable them entirely.
+  # rubocop:disable Layout
   if command('rpm')
     confine :true => begin
       rpm('--version')
@@ -29,6 +33,7 @@
         true
       end
   end
+  # rubocop:enable Layout
 
   defaultfor 'os.name' => :fedora
   notdefaultfor 'os.name' => :fedora, 'os.release.major' => (19..21).to_a

lib/puppet/provider/package/rpm.rb

@@ -31,6 +31,9 @@
 
   commands :rpm => "rpm"
 
+  # Mixing confine statements, control expressions, and exception handling
+  # confuses Rubocop's Layout cops, so we disable them entirely.
+  # rubocop:disable Layout
   if command('rpm')
     confine :true => begin
       rpm('--version')
@@ -40,6 +43,7 @@
         true
       end
   end
+  # rubocop:enable Layout
 
   def self.current_version
     return @current_version unless @current_version.nil?

lib/puppet/provider/package/tdnf.rb

@@ -16,6 +16,10 @@
   # never try to use RPM on a machine without it. We think this
   # has probably become obsolete with the way `commands` work, so
   # we should investigate removing it at some point.
+  #
+  # Mixing confine statements, control expressions, and exception handling
+  # confuses Rubocop's Layout cops, so we disable them entirely.
+  # rubocop:disable Layout
   if command('rpm')
     confine :true => begin
       rpm('--version')
@@ -25,6 +29,7 @@
         true
       end
   end
+  # rubocop:enable Layout
 
   defaultfor 'os.name' => "PhotonOS" 
 end

lib/puppet/provider/package/yum.rb

@@ -24,6 +24,9 @@
 
   commands :cmd => "yum", :rpm => "rpm"
 
+  # Mixing confine statements, control expressions, and exception handling
+  # confuses Rubocop's Layout cops, so we disable them entirely.
+  # rubocop:disable Layout
   if command('rpm')
     confine :true => begin
       rpm('--version')
@@ -33,6 +36,7 @@
         true
       end
   end
+  # rubocop:enable Layout
 
   defaultfor 'os.name' => :amazon
   defaultfor 'os.family' => :redhat, 'os.release.major' => (4..7).to_a