Layout/MultilineOperationIndentation

This commit enables the Rubocop Layout/MultilineOperationIndentation cop
and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented
-Layout/MultilineOperationIndentation:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: with_first_parameter, with_fixed_indentation

lib/hiera/puppet_function.rb

@@ -65,7 +65,7 @@ def lookup(scope, key, default, has_default, override, &default_block)
       # TRANSLATORS 'lookup' is a puppet function and should not be translated
       message = _("The function '%{class_name}' is deprecated in favor of using 'lookup'.") % { class_name: self.class.name }
       message += ' '+ _("See https://puppet.com/docs/puppet/%{minor_version}/deprecated_language.html") %
-          { minor_version: Puppet.minor_version }
+                      { minor_version: Puppet.minor_version }
       Puppet.warn_once('deprecations', self.class.name, message)
     end
     lookup_invocation = Puppet::Pops::Lookup::Invocation.new(scope, {}, {})

lib/puppet/external/dot.rb

@@ -201,19 +201,19 @@ def to_s(t = '')
             t + $tab + "label = #{stringify(@options['label'])}\n" :
             '' :
           t + $tab + 'label = "' + " \\\n" +
-          t + $tab2 + "#{stringify(@options['label'])}| \\\n" +
-          @ports.collect{ |i|
-            t + $tab2 + i.to_s
-          }.join( "| \\\n" ) + " \\\n" +
-          t + $tab + '"' + "\n"
+            t + $tab2 + "#{stringify(@options['label'])}| \\\n" +
+            @ports.collect{ |i|
+              t + $tab2 + i.to_s
+            }.join( "| \\\n" ) + " \\\n" +
+            t + $tab + '"' + "\n"
 
       t + "#{@name} [\n" +
-      @options.to_a.collect{ |i|
-        i[1] && i[0] != 'label' ?
-          t + $tab + "#{i[0]} = #{i[1]}" : nil
-      }.compact.join( ",\n" ) + ( label != '' ? ",\n" : "\n" ) +
-      label +
-      t + "]\n"
+        @options.to_a.collect{ |i|
+          i[1] && i[0] != 'label' ?
+            t + $tab + "#{i[0]} = #{i[1]}" : nil
+        }.compact.join( ",\n" ) + ( label != '' ? ",\n" : "\n" ) +
+        label +
+        t + "]\n"
     end
 
     private

lib/puppet/face/config.rb

@@ -99,7 +99,7 @@
   def warn_default_section(section_name)
     messages = []
     messages << _("No section specified; defaulting to '%{section_name}'.") %
-      { section_name: section_name }
+                { section_name: section_name }
     # TRANSLATORS '--section' is a command line option and should not be translated
     messages << _("Set the config section by using the `--section` flag.")
     # TRANSLATORS `puppet config --section user print foo` is a command line example and should not be translated

lib/puppet/face/epp.rb

@@ -95,7 +95,7 @@
       end
       if !missing_files.empty?
         raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{missing_files_list}") %
-            { missing_files_list: missing_files.map { |f| "   #{f}" }.join("\n") }
+                             { missing_files_list: missing_files.map { |f| "   #{f}" }.join("\n") }
       else
         # Exit with 1 if there were errors
         raise Puppet::Error, _("Errors while validating epp") unless status
@@ -197,7 +197,7 @@
 
         if !missing_files.empty?
           raise Puppet::Error, _("One or more file(s) specified did not exist:\n%{missing_files_list}") %
-              { missing_files_list: missing_files.collect { |f| "   #{f}" }.join("\n") }
+                               { missing_files_list: missing_files.collect { |f| "   #{f}" }.join("\n") }
         end
       end
       buffer.string

lib/puppet/face/module/install.rb

@@ -141,7 +141,7 @@
         tree = Puppet::ModuleTool.build_tree(return_value[:graph], return_value[:install_dir])
 
         "#{return_value[:install_dir]}\n" +
-        Puppet::ModuleTool.format_tree(tree)
+          Puppet::ModuleTool.format_tree(tree)
       end
     end
   end

lib/puppet/face/module/upgrade.rb

@@ -81,7 +81,7 @@
         tree = Puppet::ModuleTool.build_tree(return_value[:graph], return_value[:base_dir])
 
         "#{return_value[:base_dir]}\n" +
-        Puppet::ModuleTool.format_tree(tree)
+          Puppet::ModuleTool.format_tree(tree)
       end
     end
   end

lib/puppet/feature/libuser.rb

@@ -5,6 +5,6 @@
 
 Puppet.features.add(:libuser) {
   File.executable?("/usr/sbin/lgroupadd") and
-  File.executable?("/usr/sbin/luseradd")  and
-  Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
+    File.executable?("/usr/sbin/luseradd") and
+    Puppet::FileSystem.exist?(Puppet::Util::Libuser.getconf)
 }

lib/puppet/forge.rb

@@ -139,7 +139,7 @@ def initialize(source, data)
             Puppet::ModuleTool.parse_module_dependency(release, dep)[0..1]
           rescue ArgumentError => e
             raise ArgumentError, _("Malformed dependency: %{name}.") % { name: dep['name'] } +
-                ' ' + _("Exception was: %{detail}") % { detail: e }
+                                 ' ' + _("Exception was: %{detail}") % { detail: e }
           end
         end
       else

lib/puppet/functions/slice.rb

@@ -120,7 +120,7 @@ def asserted_slice_serving_size(pblock, slice_size)
 
     unless serving_size == 1 || serving_size == slice_size
       raise ArgumentError, _("slice(): block must define one parameter, or the same number of parameters as the given size of the slice (%{slice_size}). Block has %{serving_size}; %{parameter_names}") %
-          { slice_size: slice_size, serving_size: serving_size, parameter_names: pblock.parameter_names.join(', ') }
+                           { slice_size: slice_size, serving_size: serving_size, parameter_names: pblock.parameter_names.join(', ') }
     end
     serving_size
   end