Naming/PredicateName

This commit addresses the Rubocop Naming/PredicateName cop by either
exempting public methods with predicate names or renaming private
methods.

Author: mhashizume

.rubocop.yml

@@ -113,6 +113,9 @@ Naming/MethodName:
 Naming/MethodParameterName:
   Enabled: false
 
+Naming/PredicateName:
+  ForbiddenPrefixes: []
+
 Naming/RescuedExceptionsVariableName:
   Enabled: false
 

.rubocop_todo.yml

@@ -643,14 +643,6 @@ Lint/ToJSON:
 Lint/UnusedMethodArgument:
   Enabled: false
 
-# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
-# NamePrefix: is_, has_, have_
-# ForbiddenPrefixes: is_, has_, have_
-# AllowedMethods: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicateName:
-  Enabled: false
-
 # Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
 # SupportedStyles: inline, group
 Style/AccessModifierDeclarations:

lib/puppet/feature/base.rb

@@ -57,7 +57,7 @@ module WindowsSymlink
       require 'ffi'
       extend FFI::Library
 
-      def self.is_implemented
+      def self.is_implemented # rubocop:disable Naming/PredicateName
         begin
           ffi_lib :kernel32
           attach_function :CreateSymbolicLinkW, [:lpwstr, :lpwstr, :dword], :boolean

lib/puppet/functions/defined.rb

@@ -107,7 +107,7 @@
     required_repeated_param 'Variant[String, Type[CatalogEntry], Type[Type[CatalogEntry]]]', :vals
   end
 
-  def is_defined(scope, *vals)
+  def is_defined(scope, *vals) # rubocop:disable Naming/PredicateName
     vals.any? do |val|
       case val
       when String

lib/puppet/parameter.rb

@@ -92,13 +92,15 @@ def defaultto(value = nil, &block)
       end
     end
 
+    # rubocop:disable Naming/PredicateName
     def sensitive(value = nil, &block)
       if block
         define_method(:is_sensitive, &block)
       else
         define_method(:is_sensitive) do value end
       end
     end
+    # rubocop:enable Naming/PredicateName
 
     # Produces a documentation string.
     # If an enumeration of _valid values_ has been defined, it is appended to the documentation

lib/puppet/pops/validation/checker4_0.rb

@@ -622,20 +622,20 @@ def initial_manifest?(path, manifest_setting)
   # if none is found.
   def get_module_relative_path(file_path, modulepath_directories)
     clean_file = file_path.cleanpath.to_s
-    parent_path = modulepath_directories.find { |path_dir| is_parent_dir_of(path_dir, clean_file) }
+    parent_path = modulepath_directories.find { |path_dir| is_parent_dir_of?(path_dir, clean_file) }
     return NO_PATH if parent_path.nil?
 
     file_path.relative_path_from(Pathname.new(parent_path))
   end
   private :get_module_relative_path
 
-  def is_parent_dir_of(parent_dir, child_dir)
+  def is_parent_dir_of?(parent_dir, child_dir)
     parent_dir_path = Pathname.new(parent_dir)
     clean_parent = parent_dir_path.cleanpath.to_s + File::SEPARATOR
 
     return child_dir.start_with?(clean_parent)
   end
-  private :is_parent_dir_of
+  private :is_parent_dir_of?
 
   def dir_to_names(relative_path)
     # Downcasing here because check is case-insensitive

lib/puppet/property.rb

@@ -403,7 +403,7 @@ def property_matches?(current, desired)
   # are not already in suitable form.
   # @param value [Object] the value to format as a string
   # @return [String] a pretty printing string
-  def is_to_s(value)
+  def is_to_s(value) # rubocop:disable Naming/PredicateName
     self.class.format_value_for_display(value)
   end
 

lib/puppet/property/keyvalue.rb

@@ -33,7 +33,7 @@ def should_to_s(should_value)
         hash_to_key_value_s(should_value)
       end
 
-      def is_to_s(current_value)
+      def is_to_s(current_value) # rubocop:disable Naming/PredicateName
         hash_to_key_value_s(current_value)
       end
 

lib/puppet/property/list.rb

@@ -8,7 +8,7 @@ class Property
     #
     class List < Property
 
-      def is_to_s(currentvalue)
+      def is_to_s(currentvalue) # rubocop:disable Naming/PredicateName
         currentvalue == :absent ? super(currentvalue) : currentvalue.join(delimiter)
       end
 

lib/puppet/provider.rb

@@ -198,7 +198,7 @@ def self.optional_commands(hash)
   # @note the name ´has_command´ looks odd in an API context, but makes more sense when seen in the internal
   #   DSL context where a Provider is declaratively defined.
   # @api public
-  #
+  # rubocop:disable Naming/PredicateName
   def self.has_command(name, path, &block)
     name = name.intern
     command = CommandDefiner.define(name, path, self, &block)
@@ -210,6 +210,7 @@ def self.has_command(name, path, &block)
       return command.execute(*args)
     end
   end
+  # rubocop:enable Naming/PredicateName
 
   # Internal helper class when creating commands - undocumented.
   # @api private
@@ -230,7 +231,7 @@ def initialize(name, path, confiner)
       @custom_environment = {}
     end
 
-    def is_optional
+    def is_optional # rubocop:disable Naming/PredicateName
       @optional = true
     end