Layout/SpaceBeforeBrackets

This commit enables the Rubocop Layout/SpaceBeforeBrackets cop and
addresses all offenses.

Author: mhashizume

.rubocop.yml

@@ -30,6 +30,10 @@ Layout/IndentationWidth:
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
 
+# Explicitly enables this cop new in 1.7
+Layout/SpaceBeforeBrackets:
+  Enabled: true
+
 # puppet uses symbol booleans in types and providers to work around long standing
 # bugs when trying to manage falsey pararameters and properties
 Lint/BooleanSymbol:

lib/puppet/graph/simple_graph.rb

@@ -342,7 +342,7 @@ def remove_edge!(e)
     if edge?(e.source, e.target)
       @upstream_from.clear
       @downstream_from.clear
-      @in_to   [e.target].delete e.source if (@in_to   [e.target][e.source] -= [e]).empty?
+      @in_to[e.target].delete e.source if (@in_to[e.target][e.source] -= [e]).empty?
       @out_from[e.source].delete e.target if (@out_from[e.source][e.target] -= [e]).empty?
     end
   end