Lint/EnsureReturn

Returning from an ensure block is a code smell, because it will silently discard
whatever was raised (prior to entering the ensure). Make an exception for the
configurer code because it's already spaghetti.

Author: joshcooper

.rubocop_todo.yml

@@ -585,11 +585,6 @@ Layout/TrailingWhitespace:
 Lint/ConstantDefinitionInBlock:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Lint/EnsureReturn:
-  Exclude:
-    - 'lib/puppet/configurer.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: standard_error, runtime_error

lib/puppet/configurer.rb

@@ -504,7 +504,7 @@ def run_internal(options)
       Puppet.log_exception(detail, _("Failed to apply catalog: %{detail}") % { detail: detail })
       return nil
     ensure
-      execute_postrun_command or return nil
+      execute_postrun_command or return nil # rubocop:disable Lint/EnsureReturn
     end
   ensure
     if Puppet[:resubmit_facts]