(PUP-11767) Enable Style/DefwithParentheses

Author: tvpartytonight

.rubocop.yml

@@ -229,3 +229,6 @@ Style/CombinableLoops:
 
 Style/ColonMethodDefinition:
   Enabled: true
+
+Style/DefWithParentheses:
+  Enabled: true

lib/puppet/application.rb

@@ -372,7 +372,7 @@ def app_defaults
   # Initialize application defaults. It's usually not necessary to override this method.
   # @return [void]
   # @api public
-  def initialize_app_defaults()
+  def initialize_app_defaults
     Puppet.settings.initialize_app_defaults(app_defaults)
   end
 

lib/puppet/application/apply.rb

@@ -366,7 +366,7 @@ def apply_catalog(catalog)
 
   # Returns facts or nil
   #
-  def get_facts()
+  def get_facts
     facts = nil
     unless Puppet[:node_name_fact].empty?
       # Collect our facts.
@@ -381,7 +381,7 @@ def get_facts()
 
   # Returns the node or raises and error if node not found.
   #
-  def get_node()
+  def get_node
     node = Puppet::Node.indirection.find(Puppet[:node_name_value])
     raise _("Could not find node %{node}") % { node: Puppet[:node_name_value] } unless node
 
@@ -390,7 +390,7 @@ def get_node()
 
   # Returns either a manifest (filename) or nil if apply should use content of Puppet[:code]
   #
-  def get_manifest()
+  def get_manifest
     manifest = nil
     # Set our code or file to use.
     if options[:code] or command_line.args.length == 0

lib/puppet/daemon.rb

@@ -58,7 +58,7 @@ def daemonize
 
   # Close stdin/stdout/stderr so that we can finish our transition into 'daemon' mode.
   # @return nil
-  def self.close_streams()
+  def self.close_streams
     Puppet.debug("Closing streams for daemon mode")
     begin
       $stdin.reopen "/dev/null"
@@ -76,7 +76,7 @@ def self.close_streams()
   end
 
   # Convenience signature for calling Puppet::Daemon.close_streams
-  def close_streams()
+  def close_streams
     Puppet::Daemon.close_streams
   end
 

lib/puppet/face/help.rb

@@ -160,7 +160,7 @@ def legacy_applications
   # @return [Array] An Array of Arrays.  The outer array contains one entry per application; each
   #  element in the outer array is a pair whose first element is a String containing the application
   #  name, and whose second element is a String containing the summary for that application.
-  def all_application_summaries()
+  def all_application_summaries
     available_application_names_special_sort().inject([]) do |result, appname|
       next result if exclude_from_docs?(appname)
 
@@ -196,7 +196,7 @@ def all_application_summaries()
   COMMON = 'Common:'
   SPECIALIZED = 'Specialized:'
   BLANK = "\n"
-  def available_application_names_special_sort()
+  def available_application_names_special_sort
     full_list = Puppet::Application.available_application_names
     a_list = full_list & %w{apply agent config help lookup module resource}
     a_list = a_list.sort

lib/puppet/functions/break.rb

@@ -37,7 +37,7 @@
   dispatch :break_impl do
   end
 
-  def break_impl()
+  def break_impl
     # get file, line if available, else they are set to nil
     file, line = Puppet::Pops::PuppetStack.top_of_stack
 

lib/puppet/indirector/json.rb

@@ -50,7 +50,7 @@ def path(name, ext = '.json')
 
   private
 
-  def data_dir()
+  def data_dir
     Puppet.run_mode.server? ? Puppet[:server_datadir] : Puppet[:client_datadir]
   end
 

lib/puppet/node/environment.rb

@@ -552,7 +552,7 @@ def hash
   end
 
   # not private so it can be called in tests
-  def self.extralibs()
+  def self.extralibs
     if ENV['PUPPETLIB']
       split_path(ENV['PUPPETLIB'])
     else

lib/puppet/parser/ast/hostclass.rb

@@ -23,7 +23,7 @@ def instantiate(modname)
     return all_types
   end
 
-  def code()
+  def code
     @context[:code]
   end
 end

lib/puppet/parser/ast/pops_bridge.rb

@@ -227,7 +227,7 @@ def instantiate_NodeDefinition(o, modname)
       end
     end
 
-    def code()
+    def code
       Expression.new(:value => @value)
     end