Skip to content

Commit 5bce3bb

Browse files
committed
(PUP-12029) Add syslog and getoptlong dependencies
Running puppet with Ruby 3.3.0 prints: $ bundle exec puppet --version /home/josh/work/puppet/lib/puppet/settings.rb:4: warning: getoptlong was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add getoptlong to your Gemfile or gemspec. /home/josh/work/puppet/lib/puppet/util/feature.rb:116: warning: syslog was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add syslog to your Gemfile or gemspec. Since getoptlong is necessary to parse the command line and is a pure ruby gem, it's safe to add it as a runtime dependency in puppet.gemspec. Since syslog is a feature and requires native extensions, add it to the features group in the Gemfile (excluding Windows and JRuby). It will also need to be added to the runtime on non-Windows platforms. The versions were chosen to match what is currently shipped in ruby 3.2.4, but updates to the patch component are allowed.
1 parent 56d07e9 commit 5bce3bb

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ group(:features) do
3535
# requires native ldap headers/libs
3636
# gem 'ruby-ldap', '~> 0.9', require: false, platforms: [:ruby]
3737
gem 'puppetserver-ca', '~> 2.0', require: false
38+
gem 'syslog', '~> 0.1.1', require: false, platforms: [:ruby]
3839
gem 'CFPropertyList', ['>= 3.0.6', '< 4'], require: false
3940
end
4041

puppet.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ Gem::Specification.new do |spec|
2929
spec.add_runtime_dependency(%q<concurrent-ruby>, "~> 1.0")
3030
spec.add_runtime_dependency(%q<deep_merge>, "~> 1.0")
3131
spec.add_runtime_dependency(%q<scanf>, "~> 1.0")
32+
spec.add_runtime_dependency(%q<getoptlong>, "~> 0.2.0")
3233

3334
platform = spec.platform.to_s
3435
if platform == 'universal-darwin'

0 commit comments

Comments
 (0)