(PUP-11683) Ignore invalid tasks when listing

Previously, if a task failed validation in someway, typically with bad
metadata, then `Puppet::InfoService.tasks_per_environment` method would
error, failing to return any task info.

The desired behavior is to still list valid tasks in an environment,
even if one task is invalid.

Author: justinstoller

lib/puppet/info_service/task_information_service.rb

@@ -4,11 +4,19 @@ class Puppet::InfoService::TaskInformationService
   def self.tasks_per_environment(environment_name)
     # get the actual environment object, raise error if the named env doesn't exist
     env = Puppet.lookup(:environments).get!(environment_name)
+
     env.modules.map do |mod|
       mod.tasks.map do |task|
-        {:module => {:name => task.module.name}, :name => task.name, :metadata => task.metadata}
+        # If any task is malformed continue to list other tasks in module
+        begin
+          task.validate
+          {:module => {:name => task.module.name}, :name => task.name, :metadata => task.metadata}
+        rescue Puppet::Module::Task::Error => err
+          Puppet.log_exception(err, 'Failed to validate task')
+          nil
+        end
       end
-    end.flatten
+    end.flatten.compact
   end
 
   def self.task_data(environment_name, module_name, task_name)

spec/unit/info_service_spec.rb

@@ -33,6 +33,27 @@
         end
       end
 
+      it "returns task data for valid tasks in an environment even if invalid tasks exist" do
+        Puppet.override(:environments => env_loader) do
+          @mod = PuppetSpec::Modules.create(mod_name, modpath, {:environment => env,
+                                                                :tasks => [['atask',
+                                                                            {:name => 'atask.json',
+                                                                             :content => metadata.to_json}],
+                                                                           ['btask',
+                                                                            {:name => 'btask.json',
+                                                                             :content => metadata.to_json}],
+                                                                           ['ctask',
+                                                                            {:name => 'ctask.json',
+                                                                             :content => metadata.to_json}]]})
+          File.write("#{modpath}/#{mod_name}/tasks/atask.json", "NOT JSON")
+
+          expect(Puppet).to receive(:send_log).with(:err, 'Failed to validate task')
+
+          @tasks = Puppet::InfoService.tasks_per_environment(env_name)
+          expect(@tasks.map{|t| t[:name]}).to contain_exactly('test1::btask', 'test1::ctask')
+        end
+      end
+
       it "should throw EnvironmentNotFound if given a nonexistent environment" do
         expect{ Puppet::InfoService.tasks_per_environment('utopia') }.to raise_error(Puppet::Environments::EnvironmentNotFound)
       end