(PUP-10923) Fix launchd provider test

We have helper methods to assert service status, use them.

Author: GabrielNagy

acceptance/tests/resource/service/launchd_provider.rb

@@ -81,19 +81,16 @@ def launchctl_assert_status(host, service, expect_running)
   end
 
   # switching from stopped to running should output the correct status of the service and not 'absent'
-  step "Start the service on #{agent} when service is stopped, and check outoput" do
+  step "Start the service on #{agent} when service is stopped, and check output" do
     on agent, puppet_resource('service', svc, 'ensure=stopped')
-    on agent, puppet_resource('service', svc, 'ensure=running') do |result|
-      assert_match(/service { '#{svc}':\n  ensure.+=> 'running',\n}$/, stdout, 'Service status change failed')
-    end
+    on agent, puppet_resource('service', svc, 'ensure=running')
+    assert_service_status_on_host(agent, svc, {:ensure => 'running'})
   end
 
-   # switching from running to stopped should output the correct status of the service and not 'absent'
-  step "Start the service on #{agent} when service is running, and check outoput" do
+  # switching from running to stopped should output the correct status of the service and not 'absent'
+  step "Stop the service on #{agent} when service is running, and check output" do
     on agent, puppet_resource('service', svc, 'ensure=running')
-    on agent, puppet_resource('service', svc, 'ensure=stopped') do |result|
-      assert_match(/service { '#{svc}':\n  ensure.+=> 'stopped',\n}$/, stdout, 'Service status change failed')
-    end
+    on agent, puppet_resource('service', svc, 'ensure=stopped')
+    assert_service_status_on_host(agent, svc, {:ensure => 'stopped'})
   end
-
 end