(PUP-7362) Fail fast if there are no facts for a node

Previously, puppet lookup would return incorrect results for any target
node that had no facts cached.

For example when using the `Per-node data` hierarchy, with the path to
the data fail being the value of `$trusted[certname]`, a node that had
the said fact cached would return the correct data from its data file,
but a node which didn't have any facts cached, would default to a common
configuration file, outputting the data from there.

This is misleading since it doesn't error out, giving the impression
that the run went well, when in actuality it failed to fetch the correct
data.

This commit fixes this issue by failing the run the moment we are able
to see that the target node has no cached facts.

Author: BobosilaVictor

acceptance/tests/parser_functions/puppet_lookup_cmd.rb

@@ -318,6 +318,15 @@
 ',
 }
 
+## facts file
+file { '#{@coderoot}/facts.yaml':
+  ensure => file,
+  mode => "0644",
+  content => '---
+  my_data_key: "my_data_value"
+',
+}
+
 file { '#{@coderoot}/hieradata/global.yaml':
   ensure => file,
   mode => "0644",
@@ -2553,7 +2562,7 @@ def data()
   apply_manifest_on(master, @encmanifest, :catch_failures => true)
 
   step "--compile uses environment specified in ENC"
-  r = on(master, puppet('lookup', '--compile', "--node #{@node1}", "--confdir #{@confdir}", 'environment_key'))
+  r = on(master, puppet('lookup', '--compile', "--node #{@node1}", "--confdir #{@confdir}", "--facts #{@coderoot}/facts.yaml", 'environment_key'))
   result = r.stdout
   assert_match(
     /env-env2-ruby-function/,
@@ -2562,12 +2571,20 @@ def data()
   )
 
   step "without --compile does not use environment specified in ENC"
-  r = on(master, puppet('lookup', "--node #{@node1}", "--confdir #{@confdir}", 'environment_key'))
+  r = on(master, puppet('lookup', "--node #{@node1}", "--confdir #{@confdir}", "--facts #{@coderoot}/facts.yaml", 'environment_key'))
   result = r.stdout
   assert_match(
     /env-production hiera provided value/,
     result,
     "lookup in production environment failed"
   )
 
+  step "lookup fails when there are no facts available"
+  r = on(master, puppet('lookup', '--compile', "--node #{@node1}", "--confdir #{@confdir}", 'environment_key'), :acceptable_exit_codes => [1])
+  result = r.stderr
+  assert_match(
+    /No facts available/,
+    result,
+    "Expected to raise when there were no facts available."
+  )
 end

lib/puppet/application/lookup.rb

@@ -360,6 +360,10 @@ def generate_scope
       facts = Puppet::Node::Facts.new(node, {}) if facts.nil?
       facts.add_extra_values(given_facts) if given_facts
 
+      if facts.values.empty?
+        raise _("No facts available for target node: %{node}") % { node: node}
+      end
+
       ni = Puppet::Node.indirection
       tc = ni.terminus_class
 

spec/integration/application/lookup_spec.rb

@@ -7,7 +7,6 @@
   include PuppetSpec::Files
 
   context 'with an environment' do
-    let(:facts) { Puppet::Node::Facts.new("facts", {}) }
     let(:env_name) { 'spec' }
     let(:env_dir) { tmpdir('environments') }
     let(:environment_files) do
@@ -45,6 +44,11 @@
     let(:app) { Puppet::Application[:lookup] }
     let(:env) { Puppet::Node::Environment.create(env_name.to_sym, [File.join(populated_env_dir, env_name, 'modules')]) }
     let(:environments) { Puppet::Environments::Directories.new(populated_env_dir, []) }
+    let(:facts) { Puppet::Node::Facts.new("facts", {'my_fact' => 'my_fact_value'}) }
+
+    before do
+      allow(Puppet::Node::Facts.indirection).to receive(:find).and_return(facts)
+    end
 
     let(:populated_env_dir) do
       dir_contained_in(env_dir, environment_files)
@@ -110,7 +114,7 @@ def explain(key, options = {})
       require 'puppet/indirector/node/exec'
       require 'puppet/indirector/node/plain'
 
-      let(:node) { Puppet::Node.new('testnode', :environment => env) }
+      let(:node) { Puppet::Node.new('testnode', :facts => facts, :environment => env) }
 
       it ':plain without --compile' do
         Puppet.settings[:node_terminus] = 'exec'

spec/unit/application/lookup_spec.rb

@@ -631,6 +631,14 @@ def run_lookup(lookup)
             lookup.run_command
           }.to raise_error(/Incorrectly formatted data in .+ given via the --facts flag \(only accepts yaml and json files\)/)
         end
+
+        it "fails when a node doesn't have facts" do
+          lookup.options[:node] = "bad.node"
+          allow(lookup.command_line).to receive(:args).and_return(['c'])
+
+          expected_error = "No facts available for target node: #{lookup.options[:node]}"
+          expect { lookup.run_command }.to raise_error(RuntimeError, expected_error)
+        end
       end
     end