(PUP-11993) Cleanup Rubocop changes

This commit cleans up some changes Rubocop autocorrected such as
remove extra parenthesis and breaking down ternary operators
into more readable if/else statements.

Author: AriaXLi

lib/puppet/application/agent.rb

@@ -509,7 +509,7 @@ def enable_disable_client(agent)
   end
 
   def setup_agent
-    agent = Puppet::Agent.new(Puppet::Configurer, (!((Puppet[:onetime]))))
+    agent = Puppet::Agent.new(Puppet::Configurer, (!(Puppet[:onetime])))
 
     enable_disable_client(agent) if options[:enable] or options[:disable]
 

lib/puppet/external/dot.rb

@@ -197,9 +197,11 @@ def to_s(t = '')
       # This code is totally incomprehensible; it needs to be replaced!
 
       label = if @options['shape'] != 'record' && @ports.length == 0
-                @options['label'] ?
-                            t + $tab + "label = #{stringify(@options['label'])}\n" :
-                            ''
+                if @options['label']
+                  t + $tab + "label = #{stringify(@options['label'])}\n"
+                else
+                  ''
+                end
               else
                 t + $tab + 'label = "' + " \\\n" +
                   t + $tab2 + "#{stringify(@options['label'])}| \\\n" +

lib/puppet/module_tool/shared_behaviors.rb

@@ -139,7 +139,7 @@ def resolve_constraints(dependencies, source = [{ :name => :you }], seen = {}, a
         :path => if action == :install
                    @options[:target_dir]
                  else
-                   (@installed[mod].empty? ? @options[:target_dir] : @installed[mod].first.modulepath)
+                   @installed[mod].empty? ? @options[:target_dir] : @installed[mod].first.modulepath
                  end,
         :dependencies => []
       }

lib/puppet/pops/types/string_converter.rb

@@ -119,11 +119,11 @@ def initialize(fmt)
 
       @left  = flags.include?('-')
       @alt   = flags.include?('#')
-      @plus  = (if flags.include?(' ')
-                  :space
-                else
-                  (flags.include?('+') ? :plus : :ignore)
-                end)
+      @plus  = if flags.include?(' ')
+                 :space
+               else
+                 flags.include?('+') ? :plus : :ignore
+               end
       @zero_pad = flags.include?('0')
 
       @delimiters = nil

lib/puppet/pops/types/type_factory.rb

@@ -251,7 +251,7 @@ def self.boolean(value = nil)
     if value.nil?
       PBooleanType::DEFAULT
     else
-      (value ? PBooleanType::TRUE : PBooleanType::FALSE)
+      value ? PBooleanType::TRUE : PBooleanType::FALSE
     end
   end
 

lib/puppet/util/log.rb

@@ -257,11 +257,11 @@ def Log.reopen
 
   def self.setup_default
     Log.newdestination(
-      (if Puppet.features.syslog?
-         :syslog
-       else
-         (Puppet.features.eventlog? ? :eventlog : Puppet[:puppetdlog])
-       end)
+      if Puppet.features.syslog?
+        :syslog
+      else
+        Puppet.features.eventlog? ? :eventlog : Puppet[:puppetdlog]
+      end
     )
   end