Skip to content

Commit 77c3d66

Browse files
authored
Merge pull request #9368 from joshcooper/pending_win83
Mark some failing 8.3 Windows tests as pending
2 parents b6e9c9b + 7983df4 commit 77c3d66

File tree

5 files changed

+7
-1
lines changed

5 files changed

+7
-1
lines changed

.github/workflows/rspec_tests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
Get-ChildItem Env: | % { Write-Output "$($_.Key): $($_.Value)" }
5656
# list current OpenSSL install
5757
gem list openssl
58-
ruby -ropenssl -e 'puts \"OpenSSL Version - #{OpenSSL::OPENSSL_VERSION}\"; puts \"OpenSSL Library Version - #{OpenSSL::OPENSSL_LIBRARY_VERSION}\"'
58+
ruby -ropenssl -e 'puts "OpenSSL Version - #{OpenSSL::OPENSSL_VERSION}"; puts "OpenSSL Library Version - #{OpenSSL::OPENSSL_LIBRARY_VERSION}"'
5959
Get-Content Gemfile.lock
6060
ruby -v
6161
gem --version

spec/integration/directory_environments_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
it 'given an 8.3 style path on Windows, will config print an expanded path',
3232
:if => Puppet::Util::Platform.windows? do
33+
pending("GH runners seem to have disabled 8.3 support")
3334

3435
# ensure an 8.3 style path is set for environmentpath
3536
shortened = Puppet::Util::Windows::File.get_short_pathname(Puppet[:environmentpath])

spec/integration/node/environment_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ def a_module_in(name, dir)
3838

3939
it "should expand 8.3 paths on Windows when creating an environment",
4040
:if => Puppet::Util::Platform.windows? do
41+
pending("GH runners seem to have disabled 8.3 support")
4142

4243
# asking for short names only works on paths that exist
4344
base = Puppet::Util::Windows::File.get_short_pathname(tmpdir("env_modules"))

spec/unit/file_system_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -908,6 +908,8 @@ def increment_counter_in_multiple_processes(file, num_procs, options)
908908
end
909909

910910
it 'should expand a shortened path completely, unlike Ruby File.expand_path' do
911+
pending("GH runners seem to have disabled 8.3 support")
912+
911913
tmp_long_dir = tmpdir('super-long-thing-that-Windows-shortens')
912914
short_path = Puppet::Util::Windows::File.get_short_pathname(tmp_long_dir)
913915

spec/unit/util/autoload_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,8 @@ def with_libdir(libdir)
203203
end
204204

205205
it "autoloads from a directory whose ancestor is Windows 8.3", if: Puppet::Util::Platform.windows? do
206+
pending("GH runners seem to have disabled 8.3 support")
207+
206208
# File.expand_path will expand ~ in the last directory component only(!)
207209
# so create an ancestor directory with a long path
208210
dir = File.join(tmpdir('longpath'), 'short')

0 commit comments

Comments
 (0)