Lint/FloatComparison

Comparing floats for exact quality is error prone due to lack of precision.
Rubocop is trying to protect us from this subtle issue. However, in this
specific case, calling Float.zero? is the same thing[1] so there is no
behavior change.

[1] https://github.com/ruby/ruby/blob/b6b31f673d9514a8af8992b0f7abb8b0597d87af/internal/numeric.h#L153

Author: joshcooper

.rubocop_todo.yml

@@ -612,10 +612,6 @@ Lint/EnsureReturn:
   Exclude:
     - 'lib/puppet/configurer.rb'
 
-Lint/FloatComparison:
-  Exclude:
-    - 'lib/puppet/pops/types/types.rb'
-
 Lint/HashCompareByIdentity:
   Exclude:
     - 'lib/puppet/pops/serialization/serializer.rb'

lib/puppet/pops/types/types.rb

@@ -1879,10 +1879,8 @@ def self.new_function(type)
       def from_args(from)
         from = from.downcase if from.is_a?(String)
         case from
-        when Float
-          from != 0.0
-        when Integer
-          from != 0
+        when Float, Integer
+          !from.zero?
         when false, 'false', 'no', 'n'
           false
         else