(PUP-11841) Fix Style/RedundantFreeze

Now that all strings are frozen, it's redundant to call String#freeze.

Author: joshcooper

lib/hiera/scope.rb

@@ -4,13 +4,13 @@ class Hiera
   class Scope
     extend Forwardable
 
-    CALLING_CLASS = 'calling_class'.freeze
-    CALLING_CLASS_PATH = 'calling_class_path'.freeze
-    CALLING_MODULE = 'calling_module'.freeze
-    MODULE_NAME = 'module_name'.freeze
+    CALLING_CLASS = 'calling_class'
+    CALLING_CLASS_PATH = 'calling_class_path'
+    CALLING_MODULE = 'calling_module'
+    MODULE_NAME = 'module_name'
 
     CALLING_KEYS = [CALLING_CLASS, CALLING_CLASS_PATH, CALLING_MODULE].freeze
-    EMPTY_STRING = ''.freeze
+    EMPTY_STRING = ''
 
     attr_reader :real
 

lib/puppet/application/lookup.rb

@@ -7,7 +7,7 @@
 class Puppet::Application::Lookup < Puppet::Application
 
   RUN_HELP = _("Run 'puppet lookup --help' for more details").freeze
-  DEEP_MERGE_OPTIONS = '--knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays'.freeze
+  DEEP_MERGE_OPTIONS = '--knock-out-prefix, --sort-merged-arrays, and --merge-hash-arrays'
   TRUSTED_INFORMATION_FACTS = ["hostname", "domain", "fqdn", "clientcert"].freeze
 
   run_mode :server

lib/puppet/context/trusted_information.rb

@@ -110,12 +110,12 @@ def self.deep_freeze(object)
 
   def to_h
     {
-      'authenticated'.freeze => authenticated,
-      'certname'.freeze => certname,
-      'extensions'.freeze => extensions,
-      'hostname'.freeze => hostname,
-      'domain'.freeze => domain,
-      'external'.freeze => external,
+      'authenticated' => authenticated,
+      'certname' => certname,
+      'extensions' => extensions,
+      'hostname' => hostname,
+      'domain' => domain,
+      'external' => external,
     }.freeze
   end
 end

lib/puppet/face/help.rb

@@ -191,9 +191,9 @@ def all_application_summaries()
     end
   end
 
-  COMMON = 'Common:'.freeze
-  SPECIALIZED = 'Specialized:'.freeze
-  BLANK = "\n".freeze
+  COMMON = 'Common:'
+  SPECIALIZED = 'Specialized:'
+  BLANK = "\n"
   def available_application_names_special_sort()
     full_list = Puppet::Application.available_application_names
     a_list = full_list & %w{apply agent config help lookup module resource}

lib/puppet/file_system/path_pattern.rb

@@ -6,7 +6,7 @@ module Puppet::FileSystem
   class PathPattern
     class InvalidPattern < Puppet::Error; end
 
-    DOTDOT = '..'.freeze
+    DOTDOT = '..'
     ABSOLUTE_UNIX = /^\//
     ABSOLUTE_WINDOWS = /^[a-z]:/i
     CURRENT_DRIVE_RELATIVE_WINDOWS = /^\\/

lib/puppet/forge.rb

@@ -16,7 +16,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
 
   include Puppet::Forge::Errors
 
-  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)".freeze
+  USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)"
 
   # From https://forgeapi.puppet.com/#!/release/getReleases
   MODULE_RELEASE_EXCLUSIONS=%w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze

lib/puppet/functions.rb

@@ -685,11 +685,11 @@ class Function3x < InternalFunction
     # Table of optimized parameter names - 0 to 5 parameters
     PARAM_NAMES = [
       [],
-      ['p0'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze, 'p2'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze, 'p2'.freeze, 'p3'.freeze].freeze,
-      ['p0'.freeze, 'p1'.freeze, 'p2'.freeze, 'p3'.freeze, 'p4'.freeze].freeze,
+      ['p0'].freeze,
+      ['p0', 'p1'].freeze,
+      ['p0', 'p1', 'p2'].freeze,
+      ['p0', 'p1', 'p2', 'p3'].freeze,
+      ['p0', 'p1', 'p2', 'p3', 'p4'].freeze,
     ]
 
     # Creates an anonymous Function3x class that wraps a 3x function

lib/puppet/http.rb

@@ -8,8 +8,8 @@ module Puppet
   # @see Puppet::HTTP::Response
   # @api public
   module HTTP
-    ACCEPT_ENCODING = "gzip;q=1.0,deflate;q=0.6,identity;q=0.3".freeze
-    HEADER_PUPPET_VERSION = "X-Puppet-Version".freeze
+    ACCEPT_ENCODING = "gzip;q=1.0,deflate;q=0.6,identity;q=0.3"
+    HEADER_PUPPET_VERSION = "X-Puppet-Version"
 
     require_relative 'http/errors'
     require_relative 'http/site'

lib/puppet/http/service/ca.rb

@@ -7,7 +7,7 @@ class Puppet::HTTP::Service::Ca < Puppet::HTTP::Service
   HEADERS = { 'Accept' => 'text/plain' }.freeze
 
   # @return [String] default API for the ca service
-  API = '/puppet-ca/v1'.freeze
+  API = '/puppet-ca/v1'
 
   # Use `Puppet::HTTP::Session.route_to(:ca)` to create or get an instance of this class.
   #

lib/puppet/http/service/compiler.rb

@@ -5,7 +5,7 @@
 # @api public
 class Puppet::HTTP::Service::Compiler < Puppet::HTTP::Service
   # @return [String] Default API for the Compiler service
-  API = '/puppet/v3'.freeze
+  API = '/puppet/v3'
 
   # Use `Puppet::HTTP::Session.route_to(:puppet)` to create or get an instance of this class.
   #