Layout/SpaceAroundOperators

This commit enables the Rubocop Layout/SpaceAroundOperators cop and
addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
-# SupportedStylesForExponentOperator: space, no_space
-Layout/SpaceAroundOperators:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space

lib/hiera/puppet_function.rb

@@ -64,8 +64,8 @@ def lookup(scope, key, default, has_default, override, &default_block)
     unless Puppet[:strict] == :off
       # TRANSLATORS 'lookup' is a puppet function and should not be translated
       message = _("The function '%{class_name}' is deprecated in favor of using 'lookup'.") % { class_name: self.class.name }
-      message += ' '+ _("See https://puppet.com/docs/puppet/%{minor_version}/deprecated_language.html") %
-                      { minor_version: Puppet.minor_version }
+      message += ' ' + _("See https://puppet.com/docs/puppet/%{minor_version}/deprecated_language.html") %
+                       { minor_version: Puppet.minor_version }
       Puppet.warn_once('deprecations', self.class.name, message)
     end
     lookup_invocation = Puppet::Pops::Lookup::Invocation.new(scope, {}, {})

lib/puppet.rb

@@ -101,9 +101,9 @@ def self.clear
 
   def self.debug=(value)
     if value
-      Puppet::Util::Log.level=(:debug)
+      Puppet::Util::Log.level = (:debug)
     else
-      Puppet::Util::Log.level=(:notice)
+      Puppet::Util::Log.level = (:notice)
     end
   end
 

lib/puppet/application/doc.rb

@@ -33,7 +33,7 @@ def preinit
 
   option("--mode MODE", "-m") do |arg|
     require_relative '../../puppet/util/reference'
-    if Puppet::Util::Reference.modes.include?(arg) or arg.intern==:rdoc
+    if Puppet::Util::Reference.modes.include?(arg) or arg.intern == :rdoc
       options[:mode] = arg.intern
     else
       raise _("Invalid output mode %{arg}") % { arg: arg }
@@ -217,7 +217,7 @@ def setup_rdoc
     if @unknown_args.size > 0
       @unknown_args.each do |option|
         # force absolute path for modulepath when passed on commandline
-        if option[:opt]=="--modulepath"
+        if option[:opt] == "--modulepath"
           option[:arg] = option[:arg].split(::File::PATH_SEPARATOR).collect { |p| ::File.expand_path(p) }.join(::File::PATH_SEPARATOR)
         end
         Puppet.settings.handlearg(option[:opt], option[:arg])

lib/puppet/application/face_base.rb

@@ -248,7 +248,7 @@ def main
     # --daniel 2011-04-27
     if (arity = @action.positional_arg_count) > 0
       unless (count = arguments.length) == arity then
-        raise ArgumentError, n_("puppet %{face} %{action} takes %{arg_count} argument, but you gave %{given_count}", "puppet %{face} %{action} takes %{arg_count} arguments, but you gave %{given_count}", arity - 1) % { face: @face.name, action: @action.name, arg_count: arity-1, given_count: count-1 }
+        raise ArgumentError, n_("puppet %{face} %{action} takes %{arg_count} argument, but you gave %{given_count}", "puppet %{face} %{action} takes %{arg_count} arguments, but you gave %{given_count}", arity - 1) % { face: @face.name, action: @action.name, arg_count: arity - 1, given_count: count - 1 }
       end
     end
 

lib/puppet/file_bucket/dipper.rb

@@ -141,7 +141,7 @@ def restore(file, sum)
           changed = Puppet::FileSystem.stat(file_handle).mode
           ::File.chmod(changed | 0200, file)
         end
-        ::File.open(file, ::File::WRONLY|::File::TRUNC|::File::CREAT) { |of|
+        ::File.open(file, ::File::WRONLY | ::File::TRUNC | ::File::CREAT) { |of|
           of.binmode
           newcontents.stream do |source_stream|
             FileUtils.copy_stream(source_stream, of)

lib/puppet/file_system/file_impl.rb

@@ -54,7 +54,7 @@ def exclusive_open(path, mode, options = 'r', timeout = 300, &block)
     written = false
     while !written
       ::File.open(path, options, mode) do |rf|
-        if rf.flock(::File::LOCK_EX|::File::LOCK_NB)
+        if rf.flock(::File::LOCK_EX | ::File::LOCK_NB)
           Puppet.debug{ _("Locked '%{path}'") % { path: path } }
           yield rf
           written = true

lib/puppet/file_system/uniquefile.rb

@@ -28,7 +28,7 @@ def self.open_tmp(identifier)
 
   def initialize(basename, *rest)
     create_tmpname(basename, *rest) do |tmpname, _n, opts|
-      mode = File::RDWR|File::CREAT|File::EXCL
+      mode = File::RDWR | File::CREAT | File::EXCL
       perm = 0600
       if opts
         mode |= opts.delete(:mode) || 0
@@ -41,7 +41,7 @@ def initialize(basename, *rest)
         @tmpfile = File.open(tmpname, mode, opts)
         @tmpname = tmpname
       end
-      @mode = mode & ~(File::CREAT|File::EXCL)
+      @mode = mode & ~(File::CREAT | File::EXCL)
       perm or opts.freeze
       @opts = opts
     end

lib/puppet/forge.rb

@@ -20,7 +20,7 @@ class Puppet::Forge < SemanticPuppet::Dependency::Source
   USER_AGENT = "PMT/1.1.1 (v3; Net::HTTP)"
 
   # From https://forgeapi.puppet.com/#!/release/getReleases
-  MODULE_RELEASE_EXCLUSIONS=%w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze
+  MODULE_RELEASE_EXCLUSIONS = %w[readme changelog license uri module tags supported file_size downloads created_at updated_at deleted_at].join(',').freeze
 
   attr_reader :host, :repository
 

lib/puppet/functions.rb

@@ -547,7 +547,7 @@ def internal_param(type, name, repeat = false)
         if repeat
           @weaving << -@names.size()
         else
-          @weaving << @names.size()-1
+          @weaving << @names.size() - 1
         end
       else
         raise ArgumentError, _("Parameter 'type' must be a String reference to a Puppet Data Type. Got %{type_class}") % { type_class: type.class }
@@ -644,7 +644,7 @@ def type(assignment_string)
       end
       unless result.body.kind_of?(Puppet::Pops::Model::TypeAlias)
         rb_location = rb_location.gsub(/:in.*$/, '')
-        raise ArgumentError, _("Expected a type alias assignment on the form 'AliasType = T', got '%{assignment_string}'.\n"+
+        raise ArgumentError, _("Expected a type alias assignment on the form 'AliasType = T', got '%{assignment_string}'.\n" +
         "Called from <%{ruby_file_location}>") % {
           assignment_string: assignment_string,
           ruby_file_location: rb_location
@@ -797,7 +797,7 @@ def self.from_to_names(func_info)
       end
       # Names of parameters, up to 5 are optimized and use frozen version
       # Note that (0..count-1) produces expected empty array for count == 0, 0-n for count >= 1
-      names = count <= 5 ? PARAM_NAMES[count] : (0..count-1).map {|n| "p#{n}" }
+      names = count <= 5 ? PARAM_NAMES[count] : (0..count - 1).map {|n| "p#{n}" }
       [from, to, names]
     end
   end
@@ -857,7 +857,7 @@ def pal_compiler_param
     def inject(injection_name)
       @injections << injection_name
       # mark what should be picked for this position when dispatching
-      @weaving << [@injections.size()-1]
+      @weaving << [@injections.size() - 1]
     end
   end
 end