Layout/SpaceAroundEqualsInParameterDefault

This commit enables the Rubocop
Layout/SpaceAroundEqualsInParameterDefault cop and addresses all
offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 Layout/SpaceAroundKeyword:
   Exclude:

lib/puppet/agent.rb

@@ -24,7 +24,7 @@ class RunTimeoutError < Exception # rubocop:disable Lint/InheritException
 
   attr_reader :client_class, :client, :should_fork
 
-  def initialize(client_class, should_fork=true)
+  def initialize(client_class, should_fork = true)
     @should_fork = can_fork? && should_fork
     @client_class = client_class
   end

lib/puppet/agent/disabler.rb

@@ -23,7 +23,7 @@ def enable
   end
 
   # Stop the daemon from making any catalog runs.
-  def disable(msg=nil)
+  def disable(msg = nil)
     data = {}
     Puppet.notice _("Disabling Puppet.")
     if (!msg.nil?)

lib/puppet/application.rb

@@ -501,7 +501,7 @@ def configure_indirector_routes
   #   to log. Intended to be passed to super by subclasses.
   # @return [void]
   # @api public
-  def log_runtime_environment(extra_info=nil)
+  def log_runtime_environment(extra_info = nil)
     runtime_info = {
       'puppet_version' => Puppet.version,
       'ruby_version' => RUBY_VERSION,

lib/puppet/error.rb

@@ -5,7 +5,7 @@ module Puppet
   class Error < RuntimeError
     attr_accessor :original
 
-    def initialize(message, original=nil)
+    def initialize(message, original = nil)
       super(message.scrub)
       @original = original
     end
@@ -20,7 +20,7 @@ module ExternalFileError
     # May be called with 3 arguments for message, file, line, and exception, or
     # 4 args including the position on the line.
     #
-    def initialize(message, file=nil, line=nil, pos=nil, original=nil)
+    def initialize(message, file = nil, line = nil, pos = nil, original = nil)
       if pos.kind_of? Exception
         original = pos
         pos = nil
@@ -68,7 +68,7 @@ class ParseErrorWithIssue < Puppet::ParseError
     # @param issue_code [Symbol] The issue code
     # @param arguments [Hash{Symbol=>Object}] Issue arguments
     #
-    def initialize(message, file=nil, line=nil, pos=nil, original=nil, issue_code= nil, arguments = nil)
+    def initialize(message, file = nil, line = nil, pos = nil, original = nil, issue_code = nil, arguments = nil)
       super(message, file, line, pos, original)
       @issue_code = issue_code
       @basic_message = message

lib/puppet/face/module/list.rb

@@ -210,7 +210,7 @@ def warn_unmet_dependencies(environment)
   #     │ └── bodepd-create_resources (v0.0.1)
   #     └── puppetlabs-sqlite (v0.0.1)
   #
-  def list_build_tree(list, ancestors=[], parent=nil, params={})
+  def list_build_tree(list, ancestors = [], parent = nil, params = {})
     list.map do |mod|
       next if @seen[(mod.forge_name or mod.name)]
 

lib/puppet/file_serving/metadata.rb

@@ -126,7 +126,7 @@ def collect(source_permissions = nil)
     end
   end
 
-  def initialize(path, data={})
+  def initialize(path, data = {})
     @owner       = data.delete('owner')
     @group       = data.delete('group')
     @mode        = data.delete('mode')

lib/puppet/file_system/uniquefile.rb

@@ -65,7 +65,7 @@ def _close
   end
   protected :_close
 
-  def close(unlink_now=false)
+  def close(unlink_now = false)
     if unlink_now
       close!
     else

lib/puppet/functions/getvar.rb

@@ -58,7 +58,7 @@
     optional_block_param 'Callable', :block
   end
 
-  def invalid_variable_error(navigation, default_value=nil, &block)
+  def invalid_variable_error(navigation, default_value = nil, &block)
     _("The given string does not start with a valid variable name")
   end
 

lib/puppet/functions/lookup.rb

@@ -186,15 +186,15 @@
     optional_block_param 'BlockType',                     :block
   end
 
-  def lookup_1(scope, name, value_type=nil, merge=nil)
+  def lookup_1(scope, name, value_type = nil, merge = nil)
     do_lookup(scope, name, value_type, nil, false, {}, {}, merge)
   end
 
   def lookup_2(scope, name, value_type, merge, default_value)
     do_lookup(scope, name, value_type, default_value, true, {}, {}, merge)
   end
 
-  def lookup_3(scope, name, value_type=nil, merge=nil, &block)
+  def lookup_3(scope, name, value_type = nil, merge = nil, &block)
     do_lookup(scope, name, value_type, nil, false, {}, {}, merge, &block)
   end