Merge pull request #9025 from joshcooper/convert_module_tests

(PUP-11764) Convert module beaker tests to integration tests

Author: mhashizume

.gitattributes

@@ -0,0 +1,6 @@
+# Disable NL -> CRNL translation on Windows. This is necessary because the files on disk must
+# match the checksums in metadata.json.
+spec/fixtures/integration/application/module/environments/direnv/modules/nginx/README -text
+spec/fixtures/integration/application/module/environments/direnv/modules/nginx/metadata.json -text
+spec/fixtures/integration/application/module/environments/direnv/modules/nginx/Modulefile -text
+spec/fixtures/integration/application/module/environments/direnv/modules/nginx/manifests/init.pp -text

acceptance/.beaker.yml

@@ -7,7 +7,6 @@ xml:                         true
 timesync:                    false
 repo_proxy:                  true
 add_el_extras:               false
-forge_host:                  api-forge-aio02-petest.puppet.com
 'master-start-curl-retries': 30
 log_level:                   debug
 preserve_hosts:              onfail

acceptance/lib/puppet/acceptance/environment_utils.rb

@@ -257,18 +257,6 @@ def use_an_environment(environment, description, master_opts, envdir, confdir, o
               on(master, puppet(*(["apply", '-e', '"include testing_mod"'] + args)), :acceptable_exit_codes => (0..255)) do
                 agent_results[:puppet_apply] = result
               end
-
-              # Be aware that Puppet Module Tool will create the module directory path if it
-              # does not exist.  So these tests should be run last...
-              step "install a module into environment"
-              on(master, puppet(*(["module", "install", "pmtacceptance-nginx"] + args)), :acceptable_exit_codes => (0..255)) do
-                agent_results[:puppet_module_install] = result
-              end
-
-              step "uninstall a module from #{description} environment"
-              on(master, puppet(*(["module", "uninstall", "pmtacceptance-nginx"] + args)), :acceptable_exit_codes => (0..255)) do
-                agent_results[:puppet_module_uninstall] = result
-              end
             end
           end
         end

acceptance/tests/environment/environment_scenario-bad.rb

@@ -21,8 +21,6 @@
 
   step 'setup environments'
 
-  stub_forge_on(master)
-
   testdir                = create_tmpdir_for_user(master, 'confdir')
   puppet_conf_backup_dir = create_tmpdir_for_user(master, "puppet-conf-backup-dir")
 
@@ -47,14 +45,6 @@
                            %r{manifest =},
                            %r{config_version =}],
         },
-        :puppet_module_install   => {
-            :exit_code => 1,
-            :matches   => [%r{Could not find a directory environment named '#{env}' anywhere in the path.*#{env_path}}],
-        },
-        :puppet_module_uninstall => {
-            :exit_code => 1,
-            :matches   => [%r{Could not find a directory environment named '#{env}' anywhere in the path.*#{env_path}}],
-        },
         :puppet_apply            => {
             :exit_code => 1,
             :matches   => [%r{Could not find a directory environment named '#{env}' anywhere in the path.*#{env_path}}],