(PUP-11993) Style/NegatedIf

This commit enables the Style/NegatedIf cop and fixes 152 autocorrectable
offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -629,12 +629,6 @@ Style/MultipleComparison:
 Style/MutableConstant:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: both, prefix, postfix
-Style/NegatedIf:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/NegatedWhile:
   Exclude:

ext/windows/service/daemon.rb

@@ -153,7 +153,7 @@ def report_windows_event(type, id, message)
     rescue Exception
       # Ignore all errors
     ensure
-      if (!eventlog.nil?)
+      unless (eventlog.nil?)
         eventlog.close
       end
     end

lib/puppet/agent/disabler.rb

@@ -26,7 +26,7 @@ def enable
   def disable(msg = nil)
     data = {}
     Puppet.notice _("Disabling Puppet.")
-    if (!msg.nil?)
+    unless (msg.nil?)
       data[DISABLED_MESSAGE_JSON_KEY] = msg
     end
     disable_lockfile.lock(data)

lib/puppet/application.rb

@@ -452,7 +452,7 @@ def setup
   # @return [void]
   # @api public
   def setup_logs
-    handle_logdest_arg(Puppet[:logdest]) if !options[:setdest]
+    handle_logdest_arg(Puppet[:logdest]) unless options[:setdest]
 
     unless options[:setdest]
       if options[:debug] || options[:verbose]

lib/puppet/application/ssl.rb

@@ -160,7 +160,7 @@ def main
 
       clean(certname)
     when 'bootstrap'
-      if !Puppet::Util::Log.sendlevel?(:info)
+      unless Puppet::Util::Log.sendlevel?(:info)
         Puppet::Util::Log.level = :info
       end
       @machine.ensure_client_certificate

lib/puppet/configurer.rb

@@ -83,8 +83,8 @@ def retrieve_catalog(facts, query_options)
     else
       result = retrieve_new_catalog(facts, query_options)
 
-      if !result
-        if !Puppet[:usecacheonfailure]
+      unless result
+        unless Puppet[:usecacheonfailure]
           Puppet.warning _("Not using cache on failed catalog")
           return nil
         end

lib/puppet/configurer/downloader.rb

@@ -77,7 +77,7 @@ def default_arguments
       :noop => false,
       :max_files => -1
     }
-    if !Puppet::Util::Platform.windows?
+    unless Puppet::Util::Platform.windows?
       defargs[:owner] = Process.uid
       defargs[:group] = Process.gid
     end

lib/puppet/confine.rb

@@ -31,7 +31,7 @@ def self.test(name)
           Puppet.warning("Could not load confine test '#{name}': #{detail}")
         end
         # Could not find file
-        if !Puppet[:always_retry_plugins]
+        unless Puppet[:always_retry_plugins]
           @tests[name] = nil
         end
       end

lib/puppet/daemon.rb

@@ -115,7 +115,7 @@ def set_signal_traps
     end
 
     # extended signals not supported under windows
-    if !Puppet::Util::Platform.windows?
+    unless Puppet::Util::Platform.windows?
       signals = { :HUP => :restart, :USR1 => :reload, :USR2 => :reopen_logs }
       signals.each do |signal, method|
         Signal.trap(signal) do

lib/puppet/defaults.rb

@@ -166,7 +166,7 @@ def self.initialize_default_settings!(settings)
         values = munge(value)
         valid   = %w[deprecations undefined_variables undefined_resources]
         invalid = values - (values & valid)
-        if not invalid.empty?
+        unless invalid.empty?
           raise ArgumentError, _("Cannot disable unrecognized warning types '%{invalid}'.") % { invalid: invalid.join(',') } +
               ' ' + _("Valid values are '%{values}'.") % { values: valid.join(', ') }
         end
@@ -1104,7 +1104,7 @@ def self.initialize_default_settings!(settings)
         values = munge(value)
 
         invalid = values - Puppet.valid_file_checksum_types
-        if not invalid.empty?
+        unless invalid.empty?
           raise ArgumentError, _("Invalid value '%{value}' for parameter %{name}. Allowed values are '%{allowed_values}'") % {
             value: invalid.first, name: @name, allowed_values: Puppet.valid_file_checksum_types.join("', '")
           }