Layout/EmptyLinesAroundAttributeAccessor

This commit enables the Rubocop Layout/EmptyLinesAroundAttributeAccessor
cop and fixes all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -30,12 +30,6 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 Layout/EmptyLinesAroundBeginBody:
   Exclude:

lib/puppet/confine.rb

@@ -42,6 +42,7 @@ def self.test(name)
 
   # Mark that this confine is used for testing binary existence.
   attr_accessor :for_binary
+
   def for_binary?
     for_binary
   end

lib/puppet/confine_collection.rb

@@ -26,6 +26,7 @@ def confine(hash)
   end
 
   attr_reader :label
+
   def initialize(label)
     @label = label
     @confines = []

lib/puppet/error.rb

@@ -3,6 +3,7 @@ module Puppet
   # The base class for all Puppet errors. It can wrap another exception
   class Error < RuntimeError
     attr_accessor :original
+
     def initialize(message, original=nil)
       super(message.scrub)
       @original = original

lib/puppet/file_serving/base.rb

@@ -44,6 +44,7 @@ def initialize(path, links: nil, relative_path: nil, source: nil)
 
   # Determine how we deal with links.
   attr_reader :links
+
   def links=(value)
     value = value.to_sym
     value = :manage if value == :ignore
@@ -54,6 +55,7 @@ def links=(value)
 
   # Set our base path.
   attr_reader :path
+
   def path=(path)
     raise ArgumentError.new(_("Paths must be fully qualified")) unless Puppet::FileServing::Base.absolute?(path)
     @path = path
@@ -62,6 +64,7 @@ def path=(path)
   # Set a relative path; this is used for recursion, and sets
   # the file's path relative to the initial recursion point.
   attr_reader :relative_path
+
   def relative_path=(path)
     raise ArgumentError.new(_("Relative paths must not be fully qualified")) if Puppet::FileServing::Base.absolute?(path)
     @relative_path = path

lib/puppet/file_serving/configuration.rb

@@ -22,6 +22,7 @@ def self.configuration
   private_class_method  :new
 
   attr_reader :mounts
+
   #private :mounts
 
   # Find the right mount.  Does some shenanigans to support old-style module

lib/puppet/graph/rb_tree_map.rb

@@ -198,6 +198,7 @@ def to_hash
 
   class Node # :nodoc: all
     attr_accessor :color, :key, :value, :left, :right
+
     def initialize(key, value)
       @key = key
       @value = value

lib/puppet/interface/action.rb

@@ -57,6 +57,7 @@ def to_s() "#{@face}##{@name}" end
   # @return [Boolean]
   # @api private
   attr_accessor :default
+
   def default?
     !!@default
   end
@@ -141,6 +142,7 @@ def __render_method_name_for(type)
   # @api private
   # @return [Symbol]
   attr_reader :render_as
+
   def render_as=(value)
     @render_as = value.to_sym
   end
@@ -218,6 +220,7 @@ def deprecated?
   # The block that is executed when the action is invoked
   # @return [block]
   attr_reader :when_invoked
+
   def when_invoked=(block)
 
     internal_name = "#{@name} implementation, required on Ruby 1.8".to_sym

lib/puppet/interface/documentation.rb

@@ -267,6 +267,7 @@ def copyright(owner = nil, years = nil)
     # @return [String] Comma-separated list of copyright owners
     # @api private
     attr_reader :copyright_owner
+
     def copyright_owner=(value)
       case value
       when String then @copyright_owner = value
@@ -283,6 +284,7 @@ def copyright_owner=(value)
     # @return [String]
     # @api private
     attr_reader :copyright_years
+
     def copyright_years=(value)
       years = munge_copyright_year value
       years = (years.is_a?(Array) ? years : [years])

lib/puppet/interface/option.rb

@@ -135,6 +135,7 @@ def default
   end
 
   attr_reader :parent, :name, :aliases, :optparse, :required
+
   def required=(value)
     if has_default?
       raise ArgumentError, _("%{name} can't be optional and have a default value") % { name: self }
@@ -143,6 +144,7 @@ def required=(value)
   end
 
   attr_reader :before_action
+
   def before_action=(proc)
     unless proc.is_a? Proc
       #TRANSLATORS 'proc' is a Ruby block of code
@@ -154,6 +156,7 @@ def before_action=(proc)
   end
 
   attr_reader :after_action
+
   def after_action=(proc)
     unless proc.is_a? Proc
       #TRANSLATORS 'proc' is a Ruby block of code