(PUP-11993) Style/NumericLiterals

This commit enables the Style/NumericLiterals cop and fixes 19
autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -629,11 +629,6 @@ Style/MultipleComparison:
 Style/MutableConstant:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: Strict, AllowedNumbers.
-Style/NumericLiterals:
-  MinDigits: 11
-
 # This cop supports unsafe auto-correction (--auto-correct-all).
 # Configuration parameters: EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison

lib/puppet/defaults.rb

@@ -501,7 +501,7 @@ def self.initialize_default_settings!(settings)
                      end
     },
     :maximum_uid => {
-        :default  => 4294967290,
+        :default  => 4_294_967_290,
         :type     => :integer,
         :desc     => "The maximum allowed UID.  Some platforms use negative UIDs
           but then ship with tools that do not know how to handle signed ints,

lib/puppet/ffi/windows/constants.rb

@@ -109,7 +109,7 @@ module Constants
     # https://msdn.microsoft.com/en-us/library/windows/desktop/aa364571(v=vs.85).aspx
     FSCTL_GET_REPARSE_POINT = 0x900a8
 
-    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
+    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16_384
 
     # Priority constants
     # https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-setpriorityclass

lib/puppet/ffi/windows/structs.rb

@@ -258,7 +258,7 @@ class OSVERSIONINFO < FFI::Struct
       )
     end
 
-    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16384
+    MAXIMUM_REPARSE_DATA_BUFFER_SIZE = 16_384
 
     # SYMLINK_REPARSE_DATA_BUFFER
     # https://msdn.microsoft.com/en-us/library/cc232006.aspx

lib/puppet/pops/serialization/abstract_reader.rb

@@ -143,15 +143,15 @@ def register_types
       read_payload(data) do |ep|
         sec = ep.read
         nsec = ep.read
-        Time::Timestamp.new(sec * 1000000000 + nsec)
+        Time::Timestamp.new(sec * 1_000_000_000 + nsec)
       end
     end
 
     register_type(Extension::TIMESPAN) do |data|
       read_payload(data) do |ep|
         sec = ep.read
         nsec = ep.read
-        Time::Timespan.new(sec * 1000000000 + nsec)
+        Time::Timespan.new(sec * 1_000_000_000 + nsec)
       end
     end
 

lib/puppet/pops/serialization/abstract_writer.rb

@@ -178,11 +178,11 @@ def register_types
     end
 
     register_type(Extension::TIME, Time::Timestamp) do |o|
-      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1000000000); ep.write(nsecs % 1000000000) }
+      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1_000_000_000); ep.write(nsecs % 1_000_000_000) }
     end
 
     register_type(Extension::TIMESPAN, Time::Timespan) do |o|
-      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1000000000); ep.write(nsecs % 1000000000) }
+      build_payload { |ep| nsecs = o.nsecs; ep.write(nsecs / 1_000_000_000); ep.write(nsecs % 1_000_000_000) }
     end
 
     register_type(Extension::VERSION, SemanticPuppet::Version) do |o|

lib/puppet/pops/time/timestamp.rb

@@ -107,7 +107,7 @@ def self.parse(str, format = :default, timezone = nil)
     fraction = parsed[:sec_fraction]
 
     # Convert msec rational found in _strptime hash to usec
-    fraction = fraction * 1000000 unless fraction.nil?
+    fraction = fraction * 1_000_000 unless fraction.nil?
 
     # Create the Time instance and adjust for timezone
     parsed_time = ::Time.utc(parsed[:year], parsed[:mon], parsed[:mday], parsed[:hour], parsed[:min], parsed[:sec], fraction)

lib/puppet/provider/nameservice.rb

@@ -142,7 +142,7 @@ def self.autogen_id(field, resource_type)
       # loop.  Thanks, Ruby, for your awesome abstractions. --daniel 2012-03-23
       highest = []
       Puppet::Etc.send(database) { |entry| highest << entry.send(method) }
-      highest = highest.reject { |x| x > 65000 }.max
+      highest = highest.reject { |x| x > 65_000 }.max
 
       @prevauto = highest || 1000
     end

lib/puppet/settings/port_setting.rb

@@ -4,7 +4,7 @@ class Puppet::Settings::PortSetting < Puppet::Settings::IntegerSetting
   def munge(value)
     value = super(value)
 
-    if value < 0 || value > 65535
+    if value < 0 || value > 65_535
       raise Puppet::Settings::ValidationError, _("Value '%{value}' is not a valid port number for parameter: %{name}") % { value: value.inspect, name: @name }
     end
 

lib/puppet/type/schedule.rb

@@ -232,9 +232,9 @@ def match?(previous, now)
 
       ScheduleScales = {
         :hourly => 3600,
-        :daily => 86400,
-        :weekly => 604800,
-        :monthly => 2592000
+        :daily => 86_400,
+        :weekly => 604_800,
+        :monthly => 2_592_000
       }
       ScheduleMethods = {
         :hourly => :hour,