Skip to content

Commit b16f8e7

Browse files
committed
(PUP-11993) Move Style/PreferredHashMethods to .rubocop.yml
This commit moves Style/PreferredHashMethods from .rubocop_todo.yml to .rubocop.yml to indefinitely disable the cop. This is because enabling this cop causes 11 failures in rb_tree_map_spec.rb that relate to core functions in trees, like deleting a node and returning nil when a key can't be found.
1 parent 131c4ab commit b16f8e7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.rubocop.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,12 @@ Style/RedundantSelfAssignment:
5151
Exclude:
5252
- 'lib/puppet/context.rb'
5353

54+
# Enabling this cop causes failures in rb_tree_map_spec relating to important
55+
# function slike being unable to delete nodes and returning nil when the key
56+
# cannot be found
57+
Style/PreferredHashMethods:
58+
Enabled: false
59+
5460
# Explicitly enables this cop new in 1.7
5561
Layout/SpaceBeforeBrackets:
5662
Enabled: true

.rubocop_todo.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -646,12 +646,6 @@ Style/NumericPredicate:
646646
Style/OptionalBooleanParameter:
647647
Enabled: false
648648

649-
# This cop supports unsafe auto-correction (--auto-correct-all).
650-
# Configuration parameters: EnforcedStyle.
651-
# SupportedStyles: short, verbose
652-
Style/PreferredHashMethods:
653-
Enabled: false
654-
655649
# This cop supports safe auto-correction (--auto-correct).
656650
# Configuration parameters: EnforcedStyle.
657651
# SupportedStyles: implicit, explicit

0 commit comments

Comments
 (0)