Layout/SpaceInsideArrayLiteralBrackets

This commit enables the Rubocop Layout/SpaceInsideArrayLiteralBrackets
cop and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,13 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBrackets: space, no_space
-Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space

lib/puppet/application/device.rb

@@ -399,7 +399,7 @@ def find_resources(type, name)
     key = [type, name].join('/')
 
     if name
-      [ Puppet::Resource.indirection.find( key ) ]
+      [Puppet::Resource.indirection.find( key )]
     else
       Puppet::Resource.indirection.search( key, {} )
     end

lib/puppet/application/resource.rb

@@ -231,13 +231,13 @@ def find_or_save_resources(type, name, params)
     Puppet.override(stringify_rich: true) do
       if name
         if params.empty?
-          [ Puppet::Resource.indirection.find( key ) ]
+          [Puppet::Resource.indirection.find( key )]
         else
           resource = Puppet::Resource.new( type, name, :parameters => params )
 
           # save returns [resource that was saved, transaction log from applying the resource]
           save_result = Puppet::Resource.indirection.save(resource, key)
-          [ save_result.first ]
+          [save_result.first]
         end
       else
         if type == "file"

lib/puppet/face/help.rb

@@ -175,7 +175,7 @@ def all_application_summaries()
         rescue StandardError, LoadError
           error_message = _("!%{sub_command}! Subcommand unavailable due to error.") % { sub_command: appname }
           error_message += ' ' + _("Check error logs.")
-          result << [ error_message, '', '  ' ]
+          result << [error_message, '', '  ']
         end
       else
         begin
@@ -187,7 +187,7 @@ def all_application_summaries()
         rescue StandardError, LoadError
           error_message = _("!%{sub_command}! Subcommand unavailable due to error.") % { sub_command: appname }
           error_message += ' ' + _("Check error logs.")
-          result << [ error_message, '', '  ' ]
+          result << [error_message, '', '  ']
         end
       end
     end

lib/puppet/face/parser.rb

@@ -84,7 +84,7 @@
 
     when_rendering :json do |errors|
       unless errors.empty?
-        ignore_error_keys = [ :arguments, :environment, :node ]
+        ignore_error_keys = [:arguments, :environment, :node]
 
         data = errors.map do |file, error|
           file_errors = error.to_h.reject { |k, _| ignore_error_keys.include?(k) }

lib/puppet/ffi/windows/functions.rb

@@ -235,7 +235,7 @@ module Functions
     # );
     ffi_lib :advapi32
     attach_function_private :GetTokenInformation,
-                            [:handle, TOKEN_INFORMATION_CLASS, :lpvoid, :dword, :pdword ], :win32_bool
+                            [:handle, TOKEN_INFORMATION_CLASS, :lpvoid, :dword, :pdword], :win32_bool
 
     # https://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx
     # BOOL WINAPI GetVersionEx(

lib/puppet/file_serving/http_metadata.rb

@@ -50,7 +50,7 @@ def initialize(http_response, path = '/dev/null')
   def collect
     # Prefer the checksum_type from the indirector request options
     # but fall back to the alternative otherwise
-    [ @checksum_type, :sha256, :sha1, :md5, :mtime ].each do |type|
+    [@checksum_type, :sha256, :sha1, :md5, :mtime].each do |type|
       @checksum_type = type
       @checksum = @checksums[type]
       break if @checksum

lib/puppet/file_system/uniquefile.rb

@@ -153,7 +153,7 @@ def try_convert_to_hash(h)
 
   def tmpdir
     tmp = '.'
-    for dir in [ ENV['TMPDIR'], ENV['TMP'], ENV['TEMP'], @@systmpdir, '/tmp']
+    for dir in [ENV['TMPDIR'], ENV['TMP'], ENV['TEMP'], @@systmpdir, '/tmp']
       stat = File.stat(dir) if dir
       if stat && stat.directory? && stat.writable?
         tmp = dir

lib/puppet/indirector/file_bucket_file/file.rb

@@ -69,7 +69,7 @@ def list(request)
           filestat = Time.parse(item.stat.mtime.to_s)
           if from <= filestat and filestat <= to
             filenames.each do |filename|
-              bucket[filename] += [[ item.stat.mtime, item.parent.basename ]]
+              bucket[filename] += [[item.stat.mtime, item.parent.basename]]
             end
           end
         end

lib/puppet/indirector/rest.rb

@@ -50,7 +50,7 @@ def convert_to_http_error(response)
   # body, decompressed if necessary
   def parse_response(response)
     if response['content-type']
-      [ response['content-type'].gsub(/\s*;.*$/, ''), response.body ]
+      [response['content-type'].gsub(/\s*;.*$/, ''), response.body]
     else
       raise _("No content type in http response; cannot parse")
     end