Layout/FirstArrayElementIndentation

This commit enables the Rubocop Layout/FirstArrayElementIndentation cop
and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,23 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Layout/FirstArrayElementIndentation:
-  Exclude:
-    - 'lib/puppet/file_serving/mount/file.rb'
-    - 'lib/puppet/functions/lookup.rb'
-    - 'lib/puppet/pops/loader/static_loader.rb'
-    - 'lib/puppet/pops/model/ast.rb'
-    - 'lib/puppet/pops/model/pn_transformer.rb'
-    - 'lib/puppet/pops/resource/resource_type_impl.rb'
-    - 'lib/puppet/pops/types/iterable.rb'
-    - 'lib/puppet/pops/types/p_uri_type.rb'
-    - 'lib/puppet/pops/types/types.rb'
-    - 'lib/puppet/provider/nameservice/pw.rb'
-    - 'lib/puppet/type/file/content.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces

lib/puppet/file_serving/mount/file.rb

@@ -7,9 +7,9 @@ def self.localmap
     @localmap ||= {
       "h" => Puppet.runtime[:facter].value('networking.hostname'),
       "H" => [
-               Puppet.runtime[:facter].value('networking.hostname'),
-               Puppet.runtime[:facter].value('networking.domain')
-             ].join("."),
+        Puppet.runtime[:facter].value('networking.hostname'),
+        Puppet.runtime[:facter].value('networking.domain')
+      ].join("."),
       "d" => Puppet.runtime[:facter].value('networking.domain')
     }
   end

lib/puppet/functions/lookup.rb

@@ -213,12 +213,12 @@ def do_lookup(scope, name, value_type, default_value, has_default, override, def
 
   def hash_args(options_hash)
     [
-        options_hash['value_type'],
-        options_hash['default_value'],
-        options_hash.include?('default_value'),
-        options_hash['override'] || {},
-        options_hash['default_values_hash'] || {},
-        options_hash['merge']
+      options_hash['value_type'],
+      options_hash['default_value'],
+      options_hash.include?('default_value'),
+      options_hash['override'] || {},
+      options_hash['default_values_hash'] || {},
+      options_hash['merge']
     ]
   end
 end

lib/puppet/pops/loader/static_loader.rb

@@ -7,22 +7,22 @@ module Puppet::Pops
 module Loader
 class StaticLoader < Loader
   BUILTIN_TYPE_NAMES = %w{
-      Component
-      Exec
-      File
-      Filebucket
-      Group
-      Node
-      Notify
-      Package
-      Resources
-      Schedule
-      Service
-      Stage
-      Tidy
-      User
-      Whit
-    }.freeze
+    Component
+    Exec
+    File
+    Filebucket
+    Group
+    Node
+    Notify
+    Package
+    Resources
+    Schedule
+    Service
+    Stage
+    Tidy
+    User
+    Whit
+  }.freeze
 
   BUILTIN_TYPE_NAMES_LC = Set.new(BUILTIN_TYPE_NAMES.map { |n| n.downcase }).freeze
 

lib/puppet/pops/model/ast.rb

@@ -4572,90 +4572,90 @@ def self.register_pcore_types
 
   @@pcore_ast_initialized = true
   all_types = [
-  Parser::Locator::Locator19,
-  Model::PopsObject,
-  Model::Positioned,
-  Model::Expression,
-  Model::Nop,
-  Model::BinaryExpression,
-  Model::UnaryExpression,
-  Model::ParenthesizedExpression,
-  Model::NotExpression,
-  Model::UnaryMinusExpression,
-  Model::UnfoldExpression,
-  Model::AssignmentExpression,
-  Model::ArithmeticExpression,
-  Model::RelationshipExpression,
-  Model::AccessExpression,
-  Model::ComparisonExpression,
-  Model::MatchExpression,
-  Model::InExpression,
-  Model::BooleanExpression,
-  Model::AndExpression,
-  Model::OrExpression,
-  Model::LiteralList,
-  Model::KeyedEntry,
-  Model::LiteralHash,
-  Model::BlockExpression,
-  Model::ApplyBlockExpression,
-  Model::CaseOption,
-  Model::CaseExpression,
-  Model::QueryExpression,
-  Model::ExportedQuery,
-  Model::VirtualQuery,
-  Model::AbstractAttributeOperation,
-  Model::AttributeOperation,
-  Model::AttributesOperation,
-  Model::CollectExpression,
-  Model::Parameter,
-  Model::Definition,
-  Model::NamedDefinition,
-  Model::FunctionDefinition,
-  Model::ResourceTypeDefinition,
-  Model::QRefDefinition,
-  Model::TypeAlias,
-  Model::TypeMapping,
-  Model::TypeDefinition,
-  Model::NodeDefinition,
-  Model::HeredocExpression,
-  Model::HostClassDefinition,
-  Model::PlanDefinition,
-  Model::LambdaExpression,
-  Model::ApplyExpression,
-  Model::IfExpression,
-  Model::UnlessExpression,
-  Model::CallExpression,
-  Model::CallFunctionExpression,
-  Model::CallNamedFunctionExpression,
-  Model::CallMethodExpression,
-  Model::Literal,
-  Model::LiteralValue,
-  Model::LiteralRegularExpression,
-  Model::LiteralString,
-  Model::LiteralNumber,
-  Model::LiteralInteger,
-  Model::LiteralFloat,
-  Model::LiteralUndef,
-  Model::LiteralDefault,
-  Model::LiteralBoolean,
-  Model::TextExpression,
-  Model::ConcatenatedString,
-  Model::QualifiedName,
-  Model::ReservedWord,
-  Model::QualifiedReference,
-  Model::VariableExpression,
-  Model::EppExpression,
-  Model::RenderStringExpression,
-  Model::RenderExpression,
-  Model::ResourceBody,
-  Model::AbstractResource,
-  Model::ResourceExpression,
-  Model::ResourceDefaultsExpression,
-  Model::ResourceOverrideExpression,
-  Model::SelectorEntry,
-  Model::SelectorExpression,
-  Model::NamedAccessExpression,
-  Model::Program]
+    Parser::Locator::Locator19,
+    Model::PopsObject,
+    Model::Positioned,
+    Model::Expression,
+    Model::Nop,
+    Model::BinaryExpression,
+    Model::UnaryExpression,
+    Model::ParenthesizedExpression,
+    Model::NotExpression,
+    Model::UnaryMinusExpression,
+    Model::UnfoldExpression,
+    Model::AssignmentExpression,
+    Model::ArithmeticExpression,
+    Model::RelationshipExpression,
+    Model::AccessExpression,
+    Model::ComparisonExpression,
+    Model::MatchExpression,
+    Model::InExpression,
+    Model::BooleanExpression,
+    Model::AndExpression,
+    Model::OrExpression,
+    Model::LiteralList,
+    Model::KeyedEntry,
+    Model::LiteralHash,
+    Model::BlockExpression,
+    Model::ApplyBlockExpression,
+    Model::CaseOption,
+    Model::CaseExpression,
+    Model::QueryExpression,
+    Model::ExportedQuery,
+    Model::VirtualQuery,
+    Model::AbstractAttributeOperation,
+    Model::AttributeOperation,
+    Model::AttributesOperation,
+    Model::CollectExpression,
+    Model::Parameter,
+    Model::Definition,
+    Model::NamedDefinition,
+    Model::FunctionDefinition,
+    Model::ResourceTypeDefinition,
+    Model::QRefDefinition,
+    Model::TypeAlias,
+    Model::TypeMapping,
+    Model::TypeDefinition,
+    Model::NodeDefinition,
+    Model::HeredocExpression,
+    Model::HostClassDefinition,
+    Model::PlanDefinition,
+    Model::LambdaExpression,
+    Model::ApplyExpression,
+    Model::IfExpression,
+    Model::UnlessExpression,
+    Model::CallExpression,
+    Model::CallFunctionExpression,
+    Model::CallNamedFunctionExpression,
+    Model::CallMethodExpression,
+    Model::Literal,
+    Model::LiteralValue,
+    Model::LiteralRegularExpression,
+    Model::LiteralString,
+    Model::LiteralNumber,
+    Model::LiteralInteger,
+    Model::LiteralFloat,
+    Model::LiteralUndef,
+    Model::LiteralDefault,
+    Model::LiteralBoolean,
+    Model::TextExpression,
+    Model::ConcatenatedString,
+    Model::QualifiedName,
+    Model::ReservedWord,
+    Model::QualifiedReference,
+    Model::VariableExpression,
+    Model::EppExpression,
+    Model::RenderStringExpression,
+    Model::RenderExpression,
+    Model::ResourceBody,
+    Model::AbstractResource,
+    Model::ResourceExpression,
+    Model::ResourceDefaultsExpression,
+    Model::ResourceOverrideExpression,
+    Model::SelectorEntry,
+    Model::SelectorExpression,
+    Model::NamedAccessExpression,
+    Model::Program]
 
   # Create and register a TypeSet that corresponds to all types in the AST model
   types_map = {}

lib/puppet/pops/model/pn_transformer.rb

@@ -247,9 +247,9 @@ def transform_ReservedWord(e)
 
   def transform_ResourceBody(e)
     PN::Map.new([
-      transform(e.title).with_name('title'),
-      transform(e.operations).with_name('ops')
-    ]).as_call('resource_body')
+                  transform(e.title).with_name('title'),
+                  transform(e.operations).with_name('ops')
+                ]).as_call('resource_body')
   end
 
   def transform_ResourceDefaultsExpression(e)

lib/puppet/pops/resource/resource_type_impl.rb

@@ -90,7 +90,7 @@ def <=>(other)
     :before,
     :notify,
     :stage
-    ].freeze
+  ].freeze
 
   # Speed up lookup
   METAPARAMSET = Set.new(METAPARAMS).freeze

lib/puppet/pops/types/iterable.rb

@@ -85,9 +85,13 @@ def self.on(o, element_type = nil, infer_elements = true)
         else
           if element_type.nil? && infer_elements
             tc = TypeCalculator.singleton
-            element_type = PTupleType.new([
-              PVariantType.maybe_create(o.keys.map {|e| tc.infer_set(e) }),
-              PVariantType.maybe_create(o.values.map {|e| tc.infer_set(e) })], PHashType::KEY_PAIR_TUPLE_SIZE)
+            element_type =
+              PTupleType
+                .new([
+                       PVariantType.maybe_create(o.keys.map {|e| tc.infer_set(e) }),
+                       PVariantType.maybe_create(o.values.map {|e| tc.infer_set(e) })
+                     ],
+                     PHashType::KEY_PAIR_TUPLE_SIZE)
           end
           HashIterator.new(element_type, o.each_pair)
         end

lib/puppet/pops/types/p_uri_type.rb

@@ -37,20 +37,26 @@ class PURIType < PAnyType
     TypeFactory.optional(OPAQUE) => PStringType::NON_EMPTY,
   )
 
-  TYPE_STRING_PARAM = TypeFactory.optional(PVariantType.new([
-    PStringType::NON_EMPTY,
-    PRegexpType::DEFAULT,
-    TypeFactory.type_type(PPatternType::DEFAULT),
-    TypeFactory.type_type(PEnumType::DEFAULT),
-    TypeFactory.type_type(PNotUndefType::DEFAULT),
-    TypeFactory.type_type(PUndefType::DEFAULT),
-  ]))
-
-  TYPE_INTEGER_PARAM = TypeFactory.optional(PVariantType.new([
-    PIntegerType.new(0),
-    TypeFactory.type_type(PNotUndefType::DEFAULT),
-    TypeFactory.type_type(PUndefType::DEFAULT),
-  ]))
+  TYPE_STRING_PARAM =
+    TypeFactory
+      .optional(PVariantType
+        .new([
+               PStringType::NON_EMPTY,
+               PRegexpType::DEFAULT,
+               TypeFactory.type_type(PPatternType::DEFAULT),
+               TypeFactory.type_type(PEnumType::DEFAULT),
+               TypeFactory.type_type(PNotUndefType::DEFAULT),
+               TypeFactory.type_type(PUndefType::DEFAULT),
+             ]))
+
+  TYPE_INTEGER_PARAM =
+    TypeFactory
+      .optional(PVariantType
+        .new([
+               PIntegerType.new(0),
+               TypeFactory.type_type(PNotUndefType::DEFAULT),
+               TypeFactory.type_type(PUndefType::DEFAULT),
+             ]))
 
   TYPE_URI_PARAM_HASH_TYPE = TypeFactory.struct(
     TypeFactory.optional(SCHEME) => TYPE_STRING_PARAM,

lib/puppet/pops/types/types.rb

@@ -2051,8 +2051,8 @@ def iterable_type(guard = nil)
     else
       PIterableType.new(
         PTupleType.new([
-          PVariantType.maybe_create(@elements.map {|se| se.key_type }),
-          PVariantType.maybe_create(@elements.map {|se| se.value_type })],
+                         PVariantType.maybe_create(@elements.map {|se| se.key_type }),
+                         PVariantType.maybe_create(@elements.map {|se| se.value_type })],
                        PHashType::KEY_PAIR_TUPLE_SIZE))
     end
   end