(PUP-11767) Enable Style/EachWithObject

Author: tvpartytonight

.rubocop.yml

@@ -244,3 +244,6 @@ Style/DoubleCopDisableDirective:
 
 Style/EachForSimpleLoop:
   Enabled: true
+
+Style/EachWithObject:
+  Enabled: true

lib/puppet/confine/exists.rb

@@ -16,6 +16,6 @@ def message(value)
   end
 
   def summary
-    result.zip(values).inject([]) { |array, args| val, f = args; array << f unless val; array }
+    result.zip(values).each_with_object([]) { |args, array| val, f = args; array << f unless val; }
   end
 end

lib/puppet/confine/variable.rb

@@ -12,7 +12,7 @@ class Puppet::Confine::Variable < Puppet::Confine
   # Only returns failed values, not all required values.
   def self.summarize(confines)
     result = Hash.new { |hash, key| hash[key] = [] }
-    confines.inject(result) { |total, confine| total[confine.name] += confine.values unless confine.valid?; total }
+    confines.each_with_object(result) { |confine, total| total[confine.name] += confine.values unless confine.valid?; }
   end
 
   # This is set by ConfineCollection.

lib/puppet/face/epp.rb

@@ -180,14 +180,13 @@
           raise Puppet::Error, _("No input to parse given on command line or stdin")
         end
       else
-        templates, missing_files = args.reduce([[], []]) do |memo, file|
+        templates, missing_files = args.each_with_object([[], []]) do |file, memo|
           template_file = effective_template(file, compiler.environment)
           if template_file.nil?
             memo[1] << file
           else
             memo[0] << template_file
           end
-          memo
         end
 
         show_filename = templates.count > 1

lib/puppet/face/module/list.rb

@@ -119,9 +119,8 @@ def unmet_dependencies(environment)
     # Prepare the unmet dependencies for display on the console.
     environment.modules.sort_by { |mod| mod.name }.each do |mod|
       unmet_grouped = Hash.new { |h, k| h[k] = [] }
-      unmet_grouped = mod.unmet_dependencies.inject(unmet_grouped) do |acc, dep|
+      unmet_grouped = mod.unmet_dependencies.each_with_object(unmet_grouped) do |dep, acc|
         acc[dep[:reason]] << dep
-        acc
       end
       unmet_grouped.each do |type, deps|
         unless deps.empty?

lib/puppet/http/dns.rb

@@ -146,10 +146,9 @@ def expired?(service_name)
     # @yields [[Resolv::DNS::Resource::IN::SRV]] a group of records of
     #         the same priority
     def each_priority(records)
-      pri_hash = records.inject({}) do |groups, element|
+      pri_hash = records.each_with_object({}) do |element, groups|
         groups[element.priority] ||= []
         groups[element.priority] << element
-        groups
       end
 
       pri_hash.keys.sort.each do |key|

lib/puppet/indirector/node/exec.rb

@@ -54,7 +54,7 @@ def create_node(name, result, facts = nil)
 
   # Translate the yaml string into Ruby objects.
   def translate(name, output)
-    Puppet::Util::Yaml.safe_load(output, [Symbol]).inject({}) do |hash, data|
+    Puppet::Util::Yaml.safe_load(output, [Symbol]).each_with_object({}) do |data, hash|
       case data[0]
       when String
         hash[data[0].intern] = data[1]
@@ -63,8 +63,6 @@ def translate(name, output)
       else
         raise Puppet::Error, _("key is a %{klass}, not a string or symbol") % { klass: data[0].class }
       end
-
-      hash
     end
   rescue => detail
     raise Puppet::Error, _("Could not load external node results for %{name}: %{detail}") % { name: name, detail: detail }, detail.backtrace

lib/puppet/indirector/request.rb

@@ -68,7 +68,7 @@ def initialize(indirection_name, method, key, instance, options = {})
     self.indirection_name = indirection_name
     self.method = method
 
-    options = options.inject({}) { |hash, ary| hash[ary[0].to_sym] = ary[1]; hash }
+    options = options.each_with_object({}) { |ary, hash| hash[ary[0].to_sym] = ary[1]; }
 
     set_attributes(options)
 

lib/puppet/network/http/handler.rb

@@ -171,10 +171,9 @@ def client_cert(request)
   end
 
   def decode_params(params)
-    params.select { |key, _| allowed_parameter?(key) }.inject({}) do |result, ary|
+    params.select { |key, _| allowed_parameter?(key) }.each_with_object({}) do |ary, result|
       param, value = ary
       result[param.to_sym] = parse_parameter_value(param, value)
-      result
     end
   end
 

lib/puppet/parser/resource.rb

@@ -216,7 +216,7 @@ def set_parameter(param, value = nil)
   alias []= set_parameter
 
   def to_hash
-    parse_title.merge(@parameters.reduce({}) do |result, (_, param)|
+    parse_title.merge(@parameters.each_with_object({}) do |(_, param), result|
       value = param.value
       value = (:undef == value) ? nil : value
 
@@ -231,7 +231,6 @@ def to_hash
           result[param.name] = value
         end
       end
-      result
     end)
   end