Simplify conditional in static loader

Prior to this commit the static loader class used variable assignment in
conditionals unnecessarily and made a comparison (name_authority ==
Pcore::RUNTIME_NAME_AUTHORITY) that was always true.

This commit simplifies the conditionals to both remove the redundant
comparison and variable assignment in conditional.

Author: mhashizume

lib/puppet/pops/loader/static_loader.rb

@@ -46,9 +46,9 @@ def initialize
 
   def discover(type, error_collector = nil, name_authority = Pcore::RUNTIME_NAME_AUTHORITY)
     # Static loader only contains runtime types
-    return EMPTY_ARRAY unless type == :type && name_authority == name_authority = Pcore::RUNTIME_NAME_AUTHORITY
+    return EMPTY_ARRAY unless type == :type && name_authority == Pcore::RUNTIME_NAME_AUTHORITY
 
-    typed_names = type == :type && name_authority == Pcore::RUNTIME_NAME_AUTHORITY ? @loaded.keys : EMPTY_ARRAY
+    typed_names = @loaded.keys
     block_given? ? typed_names.select { |tn| yield(tn) } : typed_names
   end