(PUP-11767) Enable Style/HashConversion

Author: tvpartytonight

.rubocop.yml

@@ -295,3 +295,6 @@ Style/GlobalVars:
 
 Style/HashAsLastArrayItem:
   Enabled: true
+
+Style/HashConversion:
+  Enabled: true

lib/puppet/context/trusted_information.rb

@@ -54,9 +54,9 @@ def self.remote(authenticated, node_name, certificate)
       if certificate.nil?
         Puppet.info(_('TrustedInformation expected a certificate, but none was given.'))
       else
-        extensions = Hash[certificate.custom_extensions.collect do |ext|
+        extensions = certificate.custom_extensions.collect do |ext|
           [ext['oid'].freeze, ext['value'].freeze]
-        end]
+        end.to_h
       end
       new('remote', node_name, extensions, external)
     else

lib/puppet/forge.rb

@@ -146,7 +146,7 @@ def initialize(source, data)
         dependencies = []
       end
 
-      super(source, name, version, Hash[dependencies])
+      super(source, name, version, dependencies.to_h)
     end
 
     def install(dir)

lib/puppet/functions/filter.rb

@@ -96,14 +96,14 @@
   def filter_Hash_1(hash)
     result = hash.select { |x, y| yield([x, y]) }
     # Ruby 1.8.7 returns Array
-    result = Hash[result] unless result.is_a? Hash
+    result = result.to_h unless result.is_a? Hash
     result
   end
 
   def filter_Hash_2(hash)
     result = hash.select { |x, y| yield(x, y) }
     # Ruby 1.8.7 returns Array
-    result = Hash[result] unless result.is_a? Hash
+    result = result.to_h unless result.is_a? Hash
     result
   end
 

lib/puppet/generate/models/type/type.rb

@@ -40,7 +40,7 @@ def initialize(type)
               Property.new(type.paramclass(name))
             end
             sc = Puppet::Pops::Types::StringConverter.singleton
-            @title_patterns = Hash[type.title_patterns.map do |mapping|
+            @title_patterns = type.title_patterns.map do |mapping|
               [
                 sc.convert(mapping[0], '%p'),
                 sc.convert(mapping[1].map do |names|
@@ -50,7 +50,7 @@ def initialize(type)
                   names[0].to_s
                 end, '%p')
               ]
-            end]
+            end.to_h
             @isomorphic = type.isomorphic?
             # continue to emit capability as false when rendering the ERB
             # template, so that pcore modules generated prior to puppet7 can be

lib/puppet/module_tool/local_tarball.rb

@@ -56,7 +56,7 @@ def initialize(source, mod)
           dependencies = mod.dependencies.map do |dep|
             Puppet::ModuleTool.parse_module_dependency(release, dep)[0..1]
           end
-          dependencies = Hash[dependencies]
+          dependencies = dependencies.to_h
         end
 
         super(source, name, version, dependencies || {})

lib/puppet/network/http/api/server/v3/environments.rb

@@ -13,6 +13,7 @@ def initialize(env_loader)
                 @env_loader = env_loader
               end
 
+              # rubocop:disable Layout/MultilineMethodCallIndentation
               def call(request, response)
                 response
                   .respond_with(
@@ -21,7 +22,7 @@ def call(request, response)
                     Puppet::Util::Json
                       .dump({
                               "search_paths" => @env_loader.search_paths,
-                              "environments" => Hash[@env_loader.list.collect do |env|
+                              "environments" => @env_loader.list.collect do |env|
                                 [env.name, {
                                   "settings" => {
                                     "modulepath" => env.full_modulepath,
@@ -30,10 +31,11 @@ def call(request, response)
                                     "config_version" => env.config_version || '',
                                   }
                                 }]
-                              end]
+                              end.to_h
                             })
                   )
               end
+              # rubocop:enable Layout/MultilineMethodCallIndentation
 
               private
 

lib/puppet/node/environment.rb

@@ -379,7 +379,7 @@ def modules
 
   # @api private
   def modules_by_name
-    @modules_by_name ||= Hash[modules.map { |mod| [mod.name, mod] }]
+    @modules_by_name ||= modules.map { |mod| [mod.name, mod] }.to_h
   end
   private :modules_by_name
 

lib/puppet/parser/compiler.rb

@@ -191,7 +191,7 @@ def evaluate_node_classes
       # The results from Hash#partition are arrays of pairs rather than hashes,
       # so we have to convert to the forms evaluate_classes expects (Hash, and
       # Array of class names)
-      classes_with_params = Hash[classes_with_params]
+      classes_with_params = classes_with_params.to_h
       classes_without_params.map!(&:first)
     else
       classes_with_params = {}

lib/puppet/parser/scope.rb

@@ -260,7 +260,7 @@ def as_read_only
     end
 
     def to_hash
-      Hash[@params.select { |_, access| access.assigned? }.map { |name, access| [name, access.value] }]
+      @params.select { |_, access| access.assigned? }.map { |name, access| [name, access.value] }.to_h
     end
   end