Layout/ArrayAlignment

This commit enables the Rubocop Layout/ArrayAlignment cop and addresses
all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,20 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_element, with_fixed_indentation
-Layout/ArrayAlignment:
-  Exclude:
-    - 'lib/puppet/module/plan.rb'
-    - 'lib/puppet/pops/model/model_tree_dumper.rb'
-    - 'lib/puppet/pops/parser/heredoc_support.rb'
-    - 'lib/puppet/pops/parser/lexer2.rb'
-    - 'lib/puppet/provider/service/init.rb'
-    - 'lib/puppet/util/log/destinations.rb'
-    - 'lib/puppet/util/posix.rb'
-    - 'lib/puppet/util/windows/registry.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: IndentationWidth.
 Layout/AssignmentIndentation:

lib/puppet/module/plan.rb

@@ -46,11 +46,11 @@ def initialize(plan_name, module_name)
 
     ALLOWED_EXTENSIONS = %w{.pp .yaml}
     RESERVED_WORDS = %w{and application attr case class consumes default else
-        elsif environment false function if import in inherits node or private
-        produces site true type undef unless}
+                        elsif environment false function if import in inherits node or private
+                        produces site true type undef unless}
     RESERVED_DATA_TYPES = %w{any array boolean catalogentry class collection
-        callable data default enum float hash integer numeric optional pattern
-        resource runtime scalar string struct tuple type undef variant}
+                             callable data default enum float hash integer numeric optional pattern
+                             resource runtime scalar string struct tuple type undef variant}
 
     def self.is_plan_name?(name)
       return true if name =~ /^[a-z][a-z0-9_]*$/

lib/puppet/pops/model/model_tree_dumper.rb

@@ -319,21 +319,21 @@ def dump_Program(o)
 
   def dump_IfExpression o
     result = ["if", do_dump(o.test), :indent, :break,
-      ["then", :indent, do_dump(o.then_expr), :dedent]]
+              ["then", :indent, do_dump(o.then_expr), :dedent]]
     result +=
     [:break,
-      ["else", :indent, do_dump(o.else_expr), :dedent],
-      :dedent] unless is_nop? o.else_expr
+     ["else", :indent, do_dump(o.else_expr), :dedent],
+     :dedent] unless is_nop? o.else_expr
     result
   end
 
   def dump_UnlessExpression o
     result = ["unless", do_dump(o.test), :indent, :break,
-      ["then", :indent, do_dump(o.then_expr), :dedent]]
+              ["then", :indent, do_dump(o.then_expr), :dedent]]
     result +=
     [:break,
-      ["else", :indent, do_dump(o.else_expr), :dedent],
-      :dedent] unless is_nop? o.else_expr
+     ["else", :indent, do_dump(o.else_expr), :dedent],
+     :dedent] unless is_nop? o.else_expr
     result
   end
 

lib/puppet/pops/parser/heredoc_support.rb

@@ -106,10 +106,10 @@ def heredoc
         # Emit a token that provides the grammar with location information about the lines on which the heredoc
         # content is based.
         enqueue([:SUBLOCATE,
-          LexerSupport::TokenValue.new([:SUBLOCATE,
-            lines, lines.reduce(0) {|size, s| size + s.length} ],
-                                       heredoc_offset,
-                                       locator)])
+                 LexerSupport::TokenValue.new([:SUBLOCATE,
+                                               lines, lines.reduce(0) {|size, s| size + s.length} ],
+                                              heredoc_offset,
+                                              locator)])
 
         sublexer.lex_unquoted_string(str, locator, resulting_escapes, dqstring_style)
         sublexer.interpolate_uq_to(self)

lib/puppet/pops/parser/lexer2.rb

@@ -524,7 +524,7 @@ def initialize()
       end
     end
     ['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm',
-      'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '_'].each do |c|
+     'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '_'].each do |c|
       @selector[c] = lambda do
         scn = @scanner
         before = scn.pos
@@ -547,7 +547,7 @@ def initialize()
     end
 
     ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M',
-      'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z'].each do |c|
+     'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z'].each do |c|
       @selector[c] = lambda do
         scn = @scanner
         before = scn.pos

lib/puppet/provider/service/init.rb

@@ -54,9 +54,9 @@ def self.excludes
     # Prevent puppet failing on unsafe scripts from Yocto Linux
     if Puppet.runtime[:facter].value('os.family') == "cisco-wrlinux"
       excludes += %w{banner.sh bootmisc.sh checkroot.sh devpts.sh dmesg.sh
-                   hostname.sh mountall.sh mountnfs.sh populate-volatile.sh
-                   rmnologin.sh save-rtc.sh sendsigs sysfs.sh umountfs
-                   umountnfs.sh}
+                     hostname.sh mountall.sh mountnfs.sh populate-volatile.sh
+                     rmnologin.sh save-rtc.sh sendsigs sysfs.sh umountfs
+                     umountnfs.sh}
     end
     # Prevent puppet failing to get status of the new service introduced
     # by the fix for this (bug https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/982889)

lib/puppet/util/log/destinations.rb

@@ -36,7 +36,7 @@ def handle(msg)
     else
       msg.to_s.split("\n").each do |line|
         @syslog.send(msg.level, "(%s) %s" % [msg.source.to_s.delete("%"),
-            line.gsub("%", '%%')
+                                             line.gsub("%", '%%')
           ]
         )
       end

lib/puppet/util/posix.rb

@@ -4,7 +4,7 @@ module Puppet::Util::POSIX
 
   # This is a list of environment variables that we will set when we want to override the POSIX locale
   LOCALE_ENV_VARS = ['LANG', 'LC_ALL', 'LC_MESSAGES', 'LANGUAGE',
-                           'LC_COLLATE', 'LC_CTYPE', 'LC_MONETARY', 'LC_NUMERIC', 'LC_TIME']
+                     'LC_COLLATE', 'LC_CTYPE', 'LC_MONETARY', 'LC_NUMERIC', 'LC_TIME']
 
   # This is a list of user-related environment variables that we will unset when we want to provide a pristine
   # environment for "exec" runs

lib/puppet/util/windows/registry.rb

@@ -401,7 +401,8 @@ def reg_delete_key_ex(key, name, regsam = KEY64)
     # );
     ffi_lib :advapi32
     attach_function_private :RegQueryInfoKeyW,
-                            [:handle, :lpwstr, :lpdword, :lpdword, :lpdword, :lpdword, :lpdword,
-                              :lpdword, :lpdword, :lpdword, :lpdword, :pointer], :win32_long
+                            [:handle, :lpwstr, :lpdword, :lpdword, :lpdword,
+                             :lpdword, :lpdword, :lpdword, :lpdword, :lpdword,
+                             :lpdword, :pointer], :win32_long
   end
 end