some spec fixtures

Author: buzzdeee

spec/fixtures/unit/provider/package/openbsd/pkginfo.list

@@ -1,10 +1,6 @@
-bash-3.1.17         GNU Bourne Again Shell
-bzip2-1.0.3         block-sorting file compressor, unencumbered
-expat-2.0.0         XML 1.0 parser written in C
-gettext-0.14.5p1    GNU gettext
-libiconv-1.9.2p3    character set conversion library
-lzo-1.08p1          portable speedy lossless data compression library
-openvpn-2.0.6       easy-to-use, robust, and highly configurable VPN
-python-2.4.3p0      interpreted object-oriented programming language
-vim-7.0.42-no_x11   vi clone, many additional features
-wget-1.10.2p0       retrieve files from the web via HTTP, HTTPS and FTP
+autoconf--%2.13
+autoconf--%2.56
+bash--
+postfix--ldap%stable
+puppet--%8
+zstd--

spec/fixtures/unit/provider/package/openbsd/pkginfo_flavors.list

@@ -5,32 +5,6 @@
   let(:package) { Puppet::Type.type(:package).new(:name => 'bash', :provider => 'openbsd') }
   let(:provider) { described_class.new(package) }
 
-  def expect_read_from_pkgconf(lines)
-    pkgconf = double(:readlines => lines)
-    expect(Puppet::FileSystem).to receive(:exist?).with('/etc/pkg.conf').and_return(true)
-    expect(File).to receive(:open).with('/etc/pkg.conf', 'rb').and_return(pkgconf)
-  end
-
-  def expect_pkgadd_with_source(source)
-    expect(provider).to receive(:pkgadd).with([source]) do
-      expect(ENV).not_to have_key('PKG_PATH')
-    end
-  end
-
-  def expect_pkgadd_with_env_and_name(source, &block)
-    expect(ENV).not_to have_key('PKG_PATH')
-
-    expect(provider).to receive(:pkgadd).with([provider.resource[:name]]) do
-      expect(ENV).to have_key('PKG_PATH')
-      expect(ENV['PKG_PATH']).to eq(source)
-    end
-    expect(provider).to receive(:execpipe).with(['/bin/pkg_info', '-I', provider.resource[:name]]).and_yield('')
-
-    yield
-
-    expect(ENV).not_to be_key('PKG_PATH')
-  end
-
   context 'provider features' do
     it { is_expected.to be_installable }
     it { is_expected.to be_install_options }
@@ -61,20 +35,23 @@ def expect_pkgadd_with_env_and_name(source, &block)
 
     it "should return all packages when invoked" do
       fixture = File.read(my_fixture('pkginfo.list'))
-      expect(described_class).to receive(:execpipe).with(%w{/bin/pkg_info -a}).and_yield(fixture)
+      expect(described_class).to receive(:execpipe).with(%w{/bin/pkg_info -a -z}).and_yield(fixture)
       expect(described_class.instances.map(&:name).sort).to eq(
-        %w{bash bzip2 expat gettext libiconv lzo openvpn python vim wget}.sort
+        %w{autoconf%2.13 autoconf%2.56 bash postfix%stable puppet%8}.sort
       )
     end
 
     it "should return all flavors if set" do
-      fixture = File.read(my_fixture('pkginfo_flavors.list'))
-      expect(described_class).to receive(:execpipe).with(%w{/bin/pkg_info -a}).and_yield(fixture)
+      fixture = File.read(my_fixture('pkginfo.list'))
+      expect(described_class).to receive(:execpipe).with(%w{/bin/pkg_info -a -z}).and_yield(fixture)
       instances = described_class.instances.map {|p| {:name => p.get(:name),
         :ensure => p.get(:ensure), :flavor => p.get(:flavor)}}
       expect(instances.size).to eq(2)
-      expect(instances[0]).to eq({:name => 'bash', :ensure => '3.1.17', :flavor => 'static'})
-      expect(instances[1]).to eq({:name => 'vim',  :ensure => '7.0.42', :flavor => 'no_x11'})
+      expect(instances[0]).to eq({:name => 'autoconf%2.13', :ensure => 'present', :flavor => nil})
+      expect(instances[1]).to eq({:name => 'autoconf%2.56', :ensure => 'present', :flavor => nil})
+      expect(instances[2]).to eq({:name => 'bash',  :ensure => 'present', :flavor => nil})
+      expect(instances[3]).to eq({:name => 'postfix%stable',  :ensure => 'present', :flavor => 'ldap'})
+      expect(instances[4]).to eq({:name => 'puppet%8',  :ensure => 'present', :flavor => nil})
     end
   end
 
@@ -86,39 +63,6 @@ def expect_pkgadd_with_env_and_name(source, &block)
     end
   end
 
-  context "#latest"  do
-    before do
-      provider.resource[:source] = '/tmp/tcsh.tgz'
-      provider.resource[:name] = 'tcsh'
-      allow(provider).to receive(:pkginfo).with('tcsh--')
-    end
-
-    it "should return the ensure value if the package is already installed" do
-      allow(provider).to receive(:properties).and_return({:ensure => '4.2.45'})
-      allow(provider).to receive(:pkginfo).with('-Q', 'tcsh--')
-      expect(provider.latest).to eq('4.2.45')
-    end
-
-    it "should recognize a new version" do
-      pkginfo_query = 'tcsh-6.18.01p1'
-      allow(provider).to receive(:pkginfo).with('-Q', 'tcsh--').and_return(pkginfo_query)
-      expect(provider.latest).to eq('6.18.01p1')
-    end
-
-    it "should recognize a newer version" do
-      allow(provider).to receive(:properties).and_return({:ensure => '1.6.8'})
-      pkginfo_query = 'tcsh-1.6.10'
-      allow(provider).to receive(:pkginfo).with('-Q', 'tcsh--').and_return(pkginfo_query)
-      expect(provider.latest).to eq('1.6.10')
-    end
-
-    it "should recognize a package that is already the newest" do
-      pkginfo_query = 'tcsh-6.18.01p0 (installed)'
-      allow(provider).to receive(:pkginfo).with('-Q', 'tcsh--').and_return(pkginfo_query)
-      expect(provider.latest).to eq('6.18.01p0')
-    end
-  end
-
   context "#get_full_name" do
     it "should return the full unversioned package name when updating with a flavor" do
       provider.resource[:ensure] = 'latest'