Layout/SpaceAfterNot

This commit enables the Rubocop Layout/SpaceAfterNot cop and addresses
all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,10 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-Layout/SpaceAfterNot:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 Layout/SpaceAfterSemicolon:
   Exclude:

lib/puppet/agent/disabler.rb

@@ -26,7 +26,7 @@ def enable
   def disable(msg=nil)
     data = {}
     Puppet.notice _("Disabling Puppet.")
-    if (! msg.nil?)
+    if (!msg.nil?)
       data[DISABLED_MESSAGE_JSON_KEY] = msg
     end
     disable_lockfile.lock(data)

lib/puppet/application/device.rb

@@ -375,7 +375,7 @@ def main
       end
     end
 
-    if ! returns or returns.compact.empty?
+    if !returns or returns.compact.empty?
       exit(1)
     elsif options[:detailed_exitcodes]
       # Bitwise OR the return codes together, puppet style

lib/puppet/confine/any.rb

@@ -6,7 +6,7 @@ def self.summarize(confines)
   end
 
   def pass?(value)
-    !! value
+    !!value
   end
 
   def message(value)

lib/puppet/confine/boolean.rb

@@ -36,7 +36,7 @@ def values
       return @cached_value unless @cached_value.nil?
 
       # Double negate to coerce the value into a Boolean
-      calculated_value = !! @values.first.call
+      calculated_value = !!@values.first.call
       if calculated_value == passing_value
         @cached_value = [calculated_value]
       end

lib/puppet/confine/false.rb

@@ -14,7 +14,7 @@ def self.summarize(confines)
   end
 
   def pass?(value)
-    ! value
+    !value
   end
 
   def message(value)

lib/puppet/confine/feature.rb

@@ -4,7 +4,7 @@
 
 class Puppet::Confine::Feature < Puppet::Confine
   def self.summarize(confines)
-    confines.collect { |c| c.values }.flatten.uniq.find_all { |value| ! confines[0].pass?(value) }
+    confines.collect { |c| c.values }.flatten.uniq.find_all { |value| !confines[0].pass?(value) }
   end
 
   # Is the named feature available?

lib/puppet/confine/true.rb

@@ -15,7 +15,7 @@ def self.summarize(confines)
 
   def pass?(value)
     # Double negate, so we only get true or false.
-    ! ! value
+    !!value
   end
 
   def message(value)

lib/puppet/confine_collection.rb

@@ -49,6 +49,6 @@ def summary
   end
 
   def valid?
-    ! @confines.detect { |c| ! c.valid? }
+    !@confines.detect { |c| !c.valid? }
   end
 end

lib/puppet/face/epp.rb

@@ -174,7 +174,7 @@
       if options[:e]
         buffer.print dump_parse(options[:e], 'command-line-string', options, false)
       elsif args.empty?
-        if ! STDIN.tty?
+        if !STDIN.tty?
           buffer.print dump_parse(STDIN.read, 'stdin', options, false)
         else
           raise Puppet::Error, _("No input to parse given on command line or stdin")
@@ -342,7 +342,7 @@
         if options[:e]
           buffer.print render_inline(options[:e], compiler, options)
         elsif args.empty?
-          if ! STDIN.tty?
+          if !STDIN.tty?
             buffer.print render_inline(STDIN.read, compiler, options)
           else
             raise Puppet::Error, _("No input to process given on command line or stdin")