Lint/MixedRegexpCaptureTypes

Our URI regex combined both named and numbered capture groups, for example:

    (?<scheme>([^:\/?#]+):)

Defines a named capture group 'scheme' with an inner capture group:

    ([^:\/?#]+)

Ruby ignores numbered capture groups when they are mixed with named capture
groups[1], so explicitly mark the inner ones as non-capturing using '?:'

    (?:[^:\/?#]+)

This change was made to scheme, query and fragment.

[1] https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/MixedRegexpCaptureTypes

Author: joshcooper

.rubocop_todo.yml

@@ -588,10 +588,6 @@ Lint/ConstantDefinitionInBlock:
 Lint/MissingSuper:
   Enabled: false
 
-Lint/MixedRegexpCaptureTypes:
-  Exclude:
-    - 'lib/puppet/util.rb'
-
 Lint/NestedMethodDefinition:
   Exclude:
     - 'lib/puppet/pops/types/p_binary_type.rb'

lib/puppet/util.rb

@@ -332,7 +332,7 @@ def uri_to_path(uri)
   end
   module_function :uri_to_path
 
-  RFC_3986_URI_REGEX = /^(?<scheme>([^:\/?#]+):)?(?<authority>\/\/([^\/?#]*))?(?<path>[^?#]*)(\?(?<query>[^#]*))?(#(?<fragment>.*))?$/
+  RFC_3986_URI_REGEX = /^(?<scheme>(?:[^:\/?#]+):)?(?<authority>\/\/(?:[^\/?#]*))?(?<path>[^?#]*)(?:\?(?<query>[^#]*))?(?:#(?<fragment>.*))?$/
 
   # Percent-encodes a URI query parameter per RFC3986 - https://tools.ietf.org/html/rfc3986
   #