Layout/SpaceInsideParens

This commit enables the Rubocop Layout/SpaceInsideParens cop and
addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, compact, no_space
-Layout/SpaceInsideParens:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 Layout/SpaceInsidePercentLiteralDelimiters:
   Exclude:

lib/hiera/scope.rb

@@ -46,7 +46,7 @@ def safe_lookupvar(key)
         # do nothing
       when :warning
         Puppet.warn_once(Puppet::Parser::Scope::UNDEFINED_VARIABLES_KIND, _("Variable: %{name}") % { name: key },
-                         _("Undefined variable '%{name}'; %{reason}") % { name: key, reason: reason } )
+                         _("Undefined variable '%{name}'; %{reason}") % { name: key, reason: reason })
       when :error
         raise ArgumentError, _("Undefined variable '%{name}'; %{reason}") % { name: key, reason: reason }
       end

lib/puppet/application.rb

@@ -109,7 +109,7 @@ class Application
   require_relative '../puppet/util'
   include Puppet::Util
 
-  DOCPATTERN = ::File.expand_path(::File.dirname(__FILE__) + "/util/command_line/*" )
+  DOCPATTERN = ::File.expand_path(::File.dirname(__FILE__) + "/util/command_line/*")
   CommandLineArgs = Struct.new(:subcommand_name, :args)
 
   @loader = Puppet::Util::Autoload.new(self, 'puppet/application')
@@ -178,7 +178,7 @@ def controlled_run(&block)
 
     # used to declare code that handle an option
     def option(*options, &block)
-      long = options.find { |opt| opt =~ /^--/ }.gsub(/^--(?:\[no-\])?([^ =]+).*$/, '\1' ).tr('-', '_')
+      long = options.find { |opt| opt =~ /^--/ }.gsub(/^--(?:\[no-\])?([^ =]+).*$/, '\1').tr('-', '_')
       fname = "handle_#{long}".intern
       if (block_given?)
         define_method(fname, &block)

lib/puppet/application/device.rb

@@ -399,9 +399,9 @@ def find_resources(type, name)
     key = [type, name].join('/')
 
     if name
-      [Puppet::Resource.indirection.find( key )]
+      [Puppet::Resource.indirection.find(key)]
     else
-      Puppet::Resource.indirection.search( key, {} )
+      Puppet::Resource.indirection.search(key, {})
     end
   end
 

lib/puppet/application/doc.rb

@@ -116,7 +116,7 @@ module - see https://github.com/puppetlabs/puppetlabs-strings for more informati
     HELP
   end
 
-  def handle_unknown( opt, arg )
+  def handle_unknown(opt, arg)
     @unknown_args << { :opt => opt, :arg => arg }
     true
   end

lib/puppet/application/resource.rb

@@ -231,9 +231,9 @@ def find_or_save_resources(type, name, params)
     Puppet.override(stringify_rich: true) do
       if name
         if params.empty?
-          [Puppet::Resource.indirection.find( key )]
+          [Puppet::Resource.indirection.find(key)]
         else
-          resource = Puppet::Resource.new( type, name, :parameters => params )
+          resource = Puppet::Resource.new(type, name, :parameters => params)
 
           # save returns [resource that was saved, transaction log from applying the resource]
           save_result = Puppet::Resource.indirection.save(resource, key)
@@ -244,7 +244,7 @@ def find_or_save_resources(type, name, params)
           raise _("Listing all file instances is not supported.  Please specify a file or directory, e.g. puppet resource file /etc")
         end
 
-        Puppet::Resource.indirection.search( key, {} )
+        Puppet::Resource.indirection.search(key, {})
       end
     end
   end

lib/puppet/external/dot.rb

@@ -165,7 +165,7 @@ def initialize(params = {})
     end
 
     def to_s
-      ( @name && @name != "" ? "<#{@name}>" : "" ) + "#{@label}"
+      (@name && @name != "" ? "<#{@name}>" : "") + "#{@label}"
     end
   end
 
@@ -204,14 +204,14 @@ def to_s(t = '')
             t + $tab2 + "#{stringify(@options['label'])}| \\\n" +
             @ports.collect { |i|
               t + $tab2 + i.to_s
-            }.join( "| \\\n" ) + " \\\n" +
+            }.join("| \\\n") + " \\\n" +
             t + $tab + '"' + "\n"
 
       t + "#{@name} [\n" +
         @options.to_a.collect { |i|
           i[1] && i[0] != 'label' ?
             t + $tab + "#{i[0]} = #{i[1]}" : nil
-        }.compact.join( ",\n" ) + ( label != '' ? ",\n" : "\n" ) +
+        }.compact.join(",\n") + (label != '' ? ",\n" : "\n") +
         label +
         t + "]\n"
     end
@@ -242,7 +242,7 @@ def <<(thing)
     end
 
     def push(thing)
-      @nodes.push( thing )
+      @nodes.push(thing)
     end
 
     def pop
@@ -256,11 +256,11 @@ def to_s(t = '')
         val && name != 'label' ?
           t + $tab + "#{name} = #{val}" :
           name ? t + $tab + "#{name} = \"#{val}\"" : nil
-      }.compact.join( "\n" ) + "\n"
+      }.compact.join("\n") + "\n"
 
       nodes = @nodes.collect { |i|
-        i.to_s( t + $tab )
-      }.join( "\n" ) + "\n"
+        i.to_s(t + $tab)
+      }.join("\n") + "\n"
       hdr + options + nodes + t + "}\n"
     end
   end
@@ -295,7 +295,7 @@ def to_s(t = '')
           i[1] && i[0] != 'label' ?
             t + $tab + "#{i[0]} = #{i[1]}" :
             i[1] ? t + $tab + "#{i[0]} = \"#{i[1]}\"" : nil
-        }.compact.join( "\n" ) + "\n#{t}]\n"
+        }.compact.join("\n") + "\n#{t}]\n"
     end
   end
 

lib/puppet/face/parser.rb

@@ -213,7 +213,7 @@ def validate_manifest(manifest = nil)
     env = Puppet.lookup(:current_environment)
     loaders = Puppet::Pops::Loaders.new(env)
 
-    Puppet.override( { :loaders => loaders }, _('For puppet parser validate')) do
+    Puppet.override({ :loaders => loaders }, _('For puppet parser validate')) do
       begin
         validation_environment = manifest ? env.override_with(:manifest => manifest) : env
         validation_environment.check_for_reparse

lib/puppet/file_bucket/dipper.rb

@@ -177,7 +177,7 @@ def list(fromdate, todate)
 
   private
 
-  def absolutize_path( path )
+  def absolutize_path(path)
     Pathname.new(path).realpath
   end
 end

lib/puppet/file_system/windows.rb

@@ -114,8 +114,8 @@ def chmod(mode, path)
   end
 
   def read_preserve_line_endings(path)
-    contents = path.read( :mode => 'rb', :encoding => 'bom|utf-8')
-    contents = path.read( :mode => 'rb', :encoding => "bom|#{Encoding::default_external.name}") unless contents.valid_encoding?
+    contents = path.read(:mode => 'rb', :encoding => 'bom|utf-8')
+    contents = path.read(:mode => 'rb', :encoding => "bom|#{Encoding::default_external.name}") unless contents.valid_encoding?
     contents = path.read unless contents.valid_encoding?
 
     contents