(PUP-7559) Use symbols for desired ensure parameter

Puppet uses symbols to represent the desired ensure parameter, so just use
that. Also eliminated the `when` block for `absent`.

Author: joshcooper

lib/puppet/type/file/selcontext.rb

@@ -42,7 +42,7 @@ def retrieve_default_context(property)
         return nil
       end
 
-      context = self.get_selinux_default_context(@resource[:path], @resource[:ensure].to_s)
+      context = self.get_selinux_default_context(@resource[:path], @resource[:ensure])
       unless context
         return nil
       end

lib/puppet/util/selinux.rb

@@ -213,14 +213,13 @@ def selinux_label_support?(file)
   # what context a new resource being created should have.
   def get_create_mode(resource_ensure)
     mode = 0
-    return mode if resource_ensure == 'absent'
     case resource_ensure
-    when "present", "file"
-      mode = 0 | S_IFREG
-    when "directory"
-      mode = 0 | S_IFDIR
-    when "link"
-      mode = 0 | S_IFLNK
+    when :present, :file
+      mode |= S_IFREG
+    when :directory
+      mode |= S_IFDIR
+    when :link
+      mode |= S_IFLNK
     end
     mode
   end

spec/unit/type/file/selinux_spec.rb

@@ -7,7 +7,7 @@
 
     before do
       @path = make_absolute("/my/file")
-      @resource = Puppet::Type.type(:file).new :path => @path
+      @resource = Puppet::Type.type(:file).new(:path => @path, :ensure => :file)
       @sel = property.new :resource => @resource
     end
 
@@ -50,13 +50,13 @@
     end
 
     it "should handle no default gracefully" do
-      expect(@sel).to receive(:get_selinux_default_context).with(@path, @resource[:ensure].to_s).and_return(nil)
+      expect(@sel).to receive(:get_selinux_default_context).with(@path, :file).and_return(nil)
       expect(@sel.default).to be_nil
     end
 
     it "should be able to detect matchpathcon defaults" do
       allow(@sel).to receive(:debug)
-      expect(@sel).to receive(:get_selinux_default_context).with(@path, @resource[:ensure].to_s).and_return("user_u:role_r:type_t:s0")
+      expect(@sel).to receive(:get_selinux_default_context).with(@path, :file).and_return("user_u:role_r:type_t:s0")
       expectedresult = case param
         when :seluser; "user_u"
         when :selrole; "role_r"

spec/unit/util/selinux_spec.rb

@@ -177,8 +177,8 @@
         allow(Selinux).to receive(:matchpathcon).with("/root/chuj", 32768).and_return(-1)
         allow(self).to receive(:file_lstat).with("/root/chuj").and_raise(Errno::ENOENT, "/root/chuj")
 
-        expect(get_selinux_default_context("/root/chuj", "present")).to be_nil
-        expect(get_selinux_default_context("/root/chuj", "file")).to be_nil
+        expect(get_selinux_default_context("/root/chuj", :present)).to be_nil
+        expect(get_selinux_default_context("/root/chuj", :file)).to be_nil
       end
     end
 
@@ -189,7 +189,7 @@
         allow(Selinux).to receive(:matchpathcon).with("/root/chuj", 16384).and_return(-1)
         allow(self).to receive(:file_lstat).with("/root/chuj").and_raise(Errno::ENOENT, "/root/chuj")
 
-        expect(get_selinux_default_context("/root/chuj", "directory")).to be_nil
+        expect(get_selinux_default_context("/root/chuj", :directory)).to be_nil
       end
     end
 
@@ -200,7 +200,7 @@
         allow(Selinux).to receive(:matchpathcon).with("/root/chuj", 40960).and_return(-1)
         allow(self).to receive(:file_lstat).with("/root/chuj").and_raise(Errno::ENOENT, "/root/chuj")
 
-        expect(get_selinux_default_context("/root/chuj", "link")).to be_nil
+        expect(get_selinux_default_context("/root/chuj", :link)).to be_nil
       end
     end
 
@@ -394,20 +394,20 @@
 
   describe "get_create_mode" do
     it "should return 0 if the resource is absent" do
-      expect(get_create_mode("absent")).to eq(0)
+      expect(get_create_mode(:absent)).to eq(0)
     end
 
     it "should return mode with file type set to S_IFREG when resource is file" do
-      expect(get_create_mode("present")).to eq(32768)
-      expect(get_create_mode("file")).to eq(32768)
+      expect(get_create_mode(:present)).to eq(32768)
+      expect(get_create_mode(:file)).to eq(32768)
     end
 
     it "should return mode with file type set to S_IFDIR when resource is dir" do
-      expect(get_create_mode("directory")).to eq(16384)
+      expect(get_create_mode(:directory)).to eq(16384)
     end
 
     it "should return mode with file type set to S_IFLNK when resource is link" do
-      expect(get_create_mode("link")).to eq(40960)
+      expect(get_create_mode(:link)).to eq(40960)
     end
 
     it "should return 0 for everything else" do