Skip to content

Commit f6cba46

Browse files
committed
(PUP-9648) Remove dead code
The base `Puppet::Indirector::Rest#handle_response` method was deleted in ca36093 along with the code that used to call it. So the overridden `handle_response` method is never called. Also the MAJOR_VERSION_JSON_DEFAULT constant was also deleted.
1 parent 7f76724 commit f6cba46

File tree

1 file changed

+0
-13
lines changed
  • lib/puppet/indirector/report

1 file changed

+0
-13
lines changed

lib/puppet/indirector/report/rest.rb

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,6 @@ def save(request)
2020
raise convert_to_http_error(e.response)
2121
end
2222

23-
# This is called by the superclass when not using our httpclient.
24-
def handle_response(request, response)
25-
if !response.success?
26-
server_version = response[Puppet::Network::HEADER_PUPPET_VERSION]
27-
if server_version &&
28-
SemanticPuppet::Version.parse(server_version).major < Puppet::Indirector::REST::MAJOR_VERSION_JSON_DEFAULT &&
29-
Puppet[:preferred_serialization_format] != 'pson'
30-
format = Puppet[:preferred_serialization_format]
31-
raise Puppet::Error.new(_("Server version %{version} does not accept reports in '%{format}', use `preferred_serialization_format=pson`") % {version: server_version, format: format})
32-
end
33-
end
34-
end
35-
3623
private
3724

3825
def deserialize_save(content_type, body)

0 commit comments

Comments
 (0)