Lint/SelfAssignment

Author: joshcooper

.rubocop_todo.yml

@@ -661,13 +661,6 @@ Lint/RescueException:
     - 'lib/puppet/util/command_line/trollop.rb'
     - 'util/rspec_grouper'
 
-Lint/SelfAssignment:
-  Exclude:
-    - 'lib/puppet/pops/evaluator/evaluator_impl.rb'
-    - 'lib/puppet/pops/evaluator/runtime3_support.rb'
-    - 'lib/puppet/pops/validation/validator_factory_4_0.rb'
-    - 'lib/puppet/provider/nameservice/directoryservice.rb'
-
 # Configuration parameters: IgnoreImplicitReferences.
 Lint/ShadowedArgument:
   Exclude:

lib/puppet/pops/evaluator/evaluator_impl.rb

@@ -36,11 +36,6 @@ class EvaluatorImpl
 
   COMMA_SEPARATOR = ', '
 
-  # Reference to Issues name space makes it easier to refer to issues
-  # (Issues are shared with the validator).
-  #
-  Issues = Issues
-
   def initialize
     @@initialized ||= static_initialize
 

lib/puppet/pops/evaluator/runtime3_support.rb

@@ -480,8 +480,6 @@ def diagnostic_producer
 
   # Configure the severity of failures
   class SeverityProducer < Validation::SeverityProducer
-    Issues = Issues
-
     def initialize
       super
       p = self

lib/puppet/pops/validation/validator_factory_4_0.rb

@@ -4,8 +4,6 @@ module Validation
 # Configures validation suitable for 4.0
 #
 class ValidatorFactory_4_0 < Factory
-  Issues = Issues
-
   # Produces the checker to use
   def checker diagnostic_producer
     if Puppet[:tasks]

lib/puppet/provider/nameservice/directoryservice.rb

@@ -117,7 +117,7 @@ def self.generate_attribute_hash(input_hash, *type_properties)
       ds_value = input_hash[key]
       case ds_to_ns_attribute_map[ds_attribute]
         when :members
-          ds_value = ds_value # only members uses arrays so far
+          # do nothing, only members uses arrays so far
         when :gid, :uid
           # OS X stores objects like uid/gid as strings.
           # Try casting to an integer for these cases to be