Layout/FirstHashElementIndentation

This commit enables the Rubocop Layout/FirstHashElementIndentation cop
and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Layout/FirstHashElementIndentation:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: consistent, align_parentheses

lib/puppet/application/agent.rb

@@ -12,11 +12,11 @@ class Puppet::Application::Agent < Puppet::Application
 
   def app_defaults
     super.merge({
-      :catalog_terminus => :rest,
+                  :catalog_terminus => :rest,
       :catalog_cache_terminus => :json,
       :node_terminus => :rest,
       :facts_terminus => :facter,
-    })
+                })
   end
 
   def preinit

lib/puppet/application/apply.rb

@@ -172,9 +172,9 @@ def help
 
   def app_defaults
     super.merge({
-      :default_file_terminus => :file_server,
+                  :default_file_terminus => :file_server,
       :write_catalog_summary => false
-    })
+                })
   end
 
   def run_command

lib/puppet/application/device.rb

@@ -12,11 +12,11 @@ class Puppet::Application::Device < Puppet::Application
 
   def app_defaults
     super.merge({
-      :catalog_terminus => :rest,
+                  :catalog_terminus => :rest,
       :catalog_cache_terminus => :json,
       :node_terminus => :rest,
       :facts_terminus => :network_device,
-    })
+                })
   end
 
   def preinit

lib/puppet/application/lookup.rb

@@ -61,8 +61,8 @@ class Puppet::Application::Lookup < Puppet::Application
 
   def app_defaults
     super.merge({
-      :facts_terminus => 'yaml'
-    })
+                  :facts_terminus => 'yaml'
+                })
   end
 
   def setup_logs

lib/puppet/application/script.rb

@@ -114,8 +114,8 @@ def help
 
   def app_defaults
     super.merge({
-      :default_file_terminus => :file_server,
-    })
+                  :default_file_terminus => :file_server,
+                })
   end
 
   def run_command

lib/puppet/configurer.rb

@@ -669,7 +669,7 @@ def resubmit_facts
     puppet = session.route_to(:puppet)
 
     Puppet.info(_("Uploading facts for %{node} to %{server}") % {
-                  node: facts.name,
+      node: facts.name,
                   server: puppet.url.hostname})
 
     puppet.put_facts(facts.name, facts: facts, environment: Puppet.lookup(:current_environment).name.to_s)

lib/puppet/face/facts.rb

@@ -77,7 +77,7 @@
       puppet = session.route_to(:puppet)
 
       Puppet.notice(_("Uploading facts for '%{node}' to '%{server}'") % {
-                    node: Puppet[:node_name_value],
+        node: Puppet[:node_name_value],
                     server: puppet.url.hostname})
 
       puppet.put_facts(Puppet[:node_name_value], facts: facts, environment: Puppet.lookup(:current_environment).name.to_s)

lib/puppet/functions.rb

@@ -595,7 +595,7 @@ def internal_type_parse(type_string, loader)
         Puppet::Pops::Types::TypeParser.singleton.parse(type_string, loader)
       rescue StandardError => e
         raise ArgumentError, _("Parsing of type string '\"%{type_string}\"' failed with message: <%{message}>.\n") % {
-            type_string: type_string,
+          type_string: type_string,
             message: e.message
         }
       end
@@ -640,7 +640,7 @@ def type(assignment_string)
             assignment_string: assignment_string,
             message: e.message,
             ruby_file_location: rb_location
-        }
+          }
       end
       unless result.body.kind_of?(Puppet::Pops::Model::TypeAlias)
         rb_location = rb_location.gsub(/:in.*$/, '')

lib/puppet/http/service/compiler.rb

@@ -308,9 +308,9 @@ def get_filebucket_file(path, environment:, bucket_path: nil, diff_with: nil, li
   # @api public
   def put_filebucket_file(path, body:, environment:)
     headers = add_puppet_headers({
-      'Accept' => 'application/octet-stream',
+                                   'Accept' => 'application/octet-stream',
       'Content-Type' => 'application/octet-stream'
-      })
+                                 })
 
     response = @client.put(
       with_base_url("/file_bucket_file/#{path}"),