Skip to content

Commit fd7f09f

Browse files
authored
Merge pull request #9067 from mhashizume/maint/7.x/aix-5.3-setting
(maint) Removes AIX 5.3-specific setting
2 parents b73a071 + b3759a7 commit fd7f09f

File tree

2 files changed

+3
-45
lines changed

2 files changed

+3
-45
lines changed

lib/puppet/defaults.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@
33
module Puppet
44

55
def self.default_diffargs
6-
if (Puppet.runtime[:facter].value(:kernel) == "AIX" && Puppet.runtime[:facter].value(:kernelmajversion) == "5300")
7-
""
8-
else
9-
"-u"
10-
end
6+
'-u'
117
end
128

139
def self.default_digest_algorithm

spec/unit/defaults_spec.rb

Lines changed: 2 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -3,46 +3,8 @@
33

44
describe "Defaults" do
55
describe ".default_diffargs" do
6-
describe "on AIX" do
7-
before(:each) do
8-
allow(Facter).to receive(:value).with(:kernel).and_return("AIX")
9-
end
10-
11-
describe "on 5.3" do
12-
before(:each) do
13-
allow(Facter).to receive(:value).with(:kernelmajversion).and_return("5300")
14-
end
15-
16-
it "should be empty" do
17-
expect(Puppet.default_diffargs).to eq("")
18-
end
19-
end
20-
21-
[ "",
22-
nil,
23-
"6300",
24-
"7300",
25-
].each do |kernel_version|
26-
describe "on kernel version #{kernel_version.inspect}" do
27-
before(:each) do
28-
allow(Facter).to receive(:value).with(:kernelmajversion).and_return(kernel_version)
29-
end
30-
31-
it "should be '-u'" do
32-
expect(Puppet.default_diffargs).to eq("-u")
33-
end
34-
end
35-
end
36-
end
37-
38-
describe "on everything else" do
39-
before(:each) do
40-
allow(Facter).to receive(:value).with(:kernel).and_return("NOT_AIX")
41-
end
42-
43-
it "should be '-u'" do
44-
expect(Puppet.default_diffargs).to eq("-u")
45-
end
6+
it "should be '-u'" do
7+
expect(Puppet.default_diffargs).to eq("-u")
468
end
479
end
4810

0 commit comments

Comments
 (0)