Merge pull request #9018 from tvpartytonight/PA-4848_more_strict_fixes

(maint) Additional test fixes for strict

Author: tvpartytonight

acceptance/tests/i18n/modules/puppet_agent.rb

@@ -4,6 +4,9 @@
   tag 'audit:high',
       'audit:acceptance'
 
+  skip_test('i18n test module uses deprecated function; update module to resume testing.')
+  # function validate_absolute_path used https://github.com/eputnam/eputnam-i18ndemo/blob/621d06d/manifests/init.pp#L15
+
   require 'puppet/acceptance/environment_utils.rb'
   extend Puppet::Acceptance::EnvironmentUtils
 

acceptance/tests/lookup/config5_interpolation.rb

@@ -2,13 +2,17 @@
   require 'puppet/acceptance/environment_utils.rb'
   extend Puppet::Acceptance::EnvironmentUtils
 
+
 tag 'audit:high',
     'audit:integration',
     'audit:refactor',  # This test specifically tests interpolation on the master.
                        # Recommend adding an additonal test that validates
                        # lookup in a masterless setup.
     'server'
 
+  pending_test('unexpected `::roles` returning undefined here, but the test passes when strict=warning')
+  # Should revisit this in PUP-11751
+
   app_type        = File.basename(__FILE__, '.*')
   tmp_environment = mk_tmp_environment_with_teardown(master, app_type + '1')
   fq_tmp_environmentpath  = "#{environmentpath}/#{tmp_environment}"

acceptance/tests/parser_functions/hiera/lookup_data.rb

@@ -32,7 +32,6 @@
       - "yaml"
     :logger: "console"
     :hierarchy:
-      - "%{fqdn}"
       - "%{environment}"
       - "global"
 

acceptance/tests/parser_functions/hiera_array/lookup_data.rb

@@ -32,7 +32,6 @@
       - "yaml"
     :logger: "console"
     :hierarchy:
-      - "%{fqdn}"
       - "%{environment}"
       - "global"
 

acceptance/tests/parser_functions/hiera_hash/lookup_data.rb

@@ -31,7 +31,6 @@
       - "yaml"
     :logger: "console"
     :hierarchy:
-      - "%{fqdn}"
       - "%{environment}"
       - "global"