Support using commits for GClone spec searcher

This fixes a bug with the `GClone` spec searcher that caused `git clone`
to fail when provided a commit to clone. Because `git clone` does
not support cloning a specific commit (using a SHA1), it's necessary to
clone the entire repository. This updates the `git clone` command used
by the spec searcher accordingly.

Author: beechtom

lib/puppetfile-resolver/spec_searchers/git/gclone.rb

@@ -45,20 +45,21 @@ def self.metadata(puppetfile_module, resolver_ui, config)
         # @param file [String] the file you wish to read
         # @returns [String] the content of the file
         def self.clone_and_read_file(url, ref, file, config)
-          clone_cmd = ['git', 'clone', '--bare', '--depth=1', '--single-branch']
-          err_msg = ''
-          if config.proxy
-            err_msg += " with proxy #{config.proxy}: "
-            proxy = "--config \"http.proxy=#{config.proxy}\" --config \"https.proxy=#{config.proxy}\""
-            clone_cmd.push(proxy)
-          end
-
           Dir.mktmpdir(nil, config.clone_dir) do |dir|
-            clone_cmd.push("--branch=#{ref}") if ref != 'HEAD'
-            clone_cmd.push(url, dir)
-            out, err_out, process = ::PuppetfileResolver::Util.run_command(clone_cmd)
-            err_msg += err_out
-            raise err_msg unless process.success?
+            clone_cmd = ['git', 'clone', url, dir]
+            clone_cmd += ['--config', "http.proxy=#{config.proxy}", '--config', "https.proxy=#{config.proxy}"] if config.proxy
+
+            _out, err_out, process = ::PuppetfileResolver::Util.run_command(clone_cmd)
+
+            unless process.success?
+              msg = if config.proxy
+                      "Cloning #{url} with proxy #{config.proxy} failed: #{err_out}"
+                    else
+                      "Cloning #{url} failed: #{err_out}"
+                    end
+              raise msg
+            end
+
             Dir.chdir(dir) do
               content, err_out, process = ::PuppetfileResolver::Util.run_command(['git', 'show', "#{ref}:#{file}"])
               raise 'InvalidContent' unless process.success? && content.length > 2

spec/unit/puppetfile-resolver/spec_searchers/git/gclone_spec.rb

@@ -23,8 +23,7 @@
       expect(JSON.parse(content)['name']).to eq('puppetlabs-powershell')
     end
 
-    context 'with ref' do
-
+    context 'with tag' do
       let(:puppetfile_module) do
         PuppetfileModule.new(remote: url, ref: '2.1.2')
       end
@@ -34,6 +33,17 @@
         expect(JSON.parse(content)['name']).to eq('puppetlabs-powershell')
       end
     end
+
+    context 'with commit' do
+      let(:puppetfile_module) do
+        PuppetfileModule.new(remote: url, ref: '9276de695798097e8471b877a18df27f764eecda')
+      end
+
+      it 'reads metadata' do
+        content = subject.metadata(puppetfile_module, Logger.new(STDERR), config)
+        expect(JSON.parse(content)['name']).to eq('puppetlabs-powershell')
+      end
+    end
   end
 
   context 'invalid url' do