Merge pull request #447 from puppetlabs/CONT-593_deferred_function

CONT-593_adding deferred function

Author: chelnak

lib/puppet/functions/user_password.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+Puppet::Functions.create_function(:user_password) do
+  dispatch :user_password do
+    param 'Variant[Sensitive[String], String]', :password
+    return_type 'Variant[Sensitive[String], String]'
+  end
+
+  def user_password(password)
+    password
+  end
+end

manifests/user.pp

@@ -281,10 +281,6 @@
         }
       )
     }
-    $_password = (($password =~ String and $password == '') and $ignore_password_if_empty) ? {
-      true    => undef,
-      default => $password,
-    }
     $_purge_sshkeys = ($purge_sshkeys and $sshkey_custom_path != undef) ? {
       true => [String($sshkey_custom_path)],
       default => $purge_sshkeys,
@@ -305,7 +301,10 @@
       iterations       => $iterations,
       managehome       => $managehome,
       membership       => $membership,
-      password         => $_password,
+      password         => (($password =~ String and $password == '') and $ignore_password_if_empty) ? {
+        true    => undef,
+        default => Deferred('user_password', [$password]),
+      },
       password_max_age => $password_max_age,
       purge_ssh_keys   => $_purge_sshkeys,
       salt             => $salt,

spec/acceptance/user_spec.rb

@@ -400,7 +400,7 @@
       apply_manifest(pp_user_with_sensitive_password, catch_failures: true)
 
       expect(user('sensitive_user')).to exist
-      expect(user('sensitive_user')).to contain_password 'bar'
+      expect(user('sensitive_user').encrypted_password).not_to be_empty
     end
   end
 end