Correct RSpec/ImplicitSubject

Author: LukasAud

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-04-05 09:14:52 UTC using RuboCop version 1.48.1.
+# on 2023-04-05 10:28:45 UTC using RuboCop version 1.48.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -56,19 +56,18 @@ RSpec/DescribeClass:
 RSpec/ExampleLength:
   Max: 24
 
+# Offense count: 25
+RSpec/MultipleExpectations:
+  Max: 22
+
 # Offense count: 20
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
-RSpec/ImplicitSubject:
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
+RSpec/NamedSubject:
   Exclude:
     - 'spec/defines/accounts_user_spec.rb'
     - 'spec/functions/accounts_ssh_authorized_keys_line_parser_spec.rb'
 
-# Offense count: 25
-RSpec/MultipleExpectations:
-  Max: 22
-
 # Offense count: 29
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:

spec/defines/accounts_user_spec.rb

@@ -30,19 +30,19 @@
           let(:params) { {} }
 
           it do
-            is_expected.to contain_user(title).with('shell'        => '/bin/bash')
-            is_expected.to contain_user(title).with('home'         => user_vars[:dan_home])
-            is_expected.to contain_user(title).with('ensure'       => 'present')
-            is_expected.to contain_user(title).with('comment'      => title)
-            is_expected.to contain_user(title).with('gid'          => title)
-            is_expected.to contain_user(title).with('groups'       => [])
-            is_expected.to contain_user(title).with('allowdupe'    => false)
-            is_expected.to contain_user(title).with('managehome'   => true)
+            expect(subject).to contain_user(title).with('shell'        => '/bin/bash')
+            expect(subject).to contain_user(title).with('home'         => user_vars[:dan_home])
+            expect(subject).to contain_user(title).with('ensure'       => 'present')
+            expect(subject).to contain_user(title).with('comment'      => title)
+            expect(subject).to contain_user(title).with('gid'          => title)
+            expect(subject).to contain_user(title).with('groups'       => [])
+            expect(subject).to contain_user(title).with('allowdupe'    => false)
+            expect(subject).to contain_user(title).with('managehome'   => true)
           end
 
           it do
-            is_expected.to contain_group(title).with('ensure'      => 'present')
-            is_expected.to contain_group(title).with('gid'         => nil)
+            expect(subject).to contain_group(title).with('ensure'      => 'present')
+            expect(subject).to contain_group(title).with('gid'         => nil)
           end
         end
 
@@ -75,16 +75,16 @@
             it { is_expected.to contain_user(title).with(param.to_s => params[param]) }
           end
           it do
-            is_expected.to contain_user(title).with('gid' => params[:group])
-            is_expected.to contain_group(params[:group]).with('ensure' => params[:ensure],
-                                                              'gid' => params[:gid])
+            expect(subject).to contain_user(title).with('gid' => params[:group])
+            expect(subject).to contain_group(params[:group]).with('ensure' => params[:ensure],
+                                                                  'gid' => params[:gid])
           end
 
           it { is_expected.to contain_group(params[:group]).that_comes_before("User[#{title}]") }
 
           it do
-            is_expected.to contain_accounts__home_dir(params[:home]).with('user' => title,
-                                                                          'mode' => params[:home_mode])
+            expect(subject).to contain_accounts__home_dir(params[:home]).with('user' => title,
+                                                                              'mode' => params[:home_mode])
           end
 
           it { is_expected.to contain_accounts__key_management("#{title}_key_management").with('sshkeys' => params[:sshkeys]) }

spec/functions/accounts_ssh_authorized_keys_line_parser_spec.rb

@@ -4,38 +4,38 @@
 
 describe 'accounts_ssh_authorized_keys_line_parser' do
   it {
-    is_expected.not_to eq(nil)
+    expect(subject).not_to eq(nil)
   }
 
   it {
-    is_expected.to run.with_params('').and_raise_error(ArgumentError, %r{Wrong Keyline format!})
+    expect(subject).to run.with_params('').and_raise_error(ArgumentError, %r{Wrong Keyline format!})
   }
 
   it {
-    is_expected.to run.with_params('options unknown-keytype key comment').and_raise_error(ArgumentError, %r{Wrong Keyline format!})
+    expect(subject).to run.with_params('options unknown-keytype key comment').and_raise_error(ArgumentError, %r{Wrong Keyline format!})
   }
 
   it {
-    is_expected.to run.with_params('ssh-xyz key name with spaces').and_return( \
+    expect(subject).to run.with_params('ssh-xyz key name with spaces').and_return( \
       ['', 'ssh-xyz', 'key', 'name with spaces'],
     )
   }
 
   it {
-    is_expected.to run.with_params('"options with arguments",moreoptions,"moreoptions with arguments" ecdsa-xyz key name with spaces').and_return( \
+    expect(subject).to run.with_params('"options with arguments",moreoptions,"moreoptions with arguments" ecdsa-xyz key name with spaces').and_return( \
       ['"options with arguments",moreoptions,"moreoptions with arguments"', 'ecdsa-xyz', 'key', 'name with spaces'],
     )
   }
 
   it {
-    is_expected.to run.with_params('tunnel="0",command="sh /etc/netstart tun0" ssh-rsa AAAA...== [email protected]').and_return( \
+    expect(subject).to run.with_params('tunnel="0",command="sh /etc/netstart tun0" ssh-rsa AAAA...== [email protected]').and_return( \
       ['tunnel="0",command="sh /etc/netstart tun0"', 'ssh-rsa', 'AAAA...==', '[email protected]'],
     )
   }
 
   it {
     # rubocop:disable Layout/LineLength
-    is_expected.to run.with_params('command="rsync --server --sender -vlHogtpr --numeric-ids . /",from="192.168.1.1",no-port-forwarding,no-X11-forwarding,no-agent-forwarding ecdsa-sha2-nistp384 AAAA...= rsync backup').and_return( \
+    expect(subject).to run.with_params('command="rsync --server --sender -vlHogtpr --numeric-ids . /",from="192.168.1.1",no-port-forwarding,no-X11-forwarding,no-agent-forwarding ecdsa-sha2-nistp384 AAAA...= rsync backup').and_return( \
       ['command="rsync --server --sender -vlHogtpr --numeric-ids . /",from="192.168.1.1",no-port-forwarding,no-X11-forwarding,no-agent-forwarding', 'ecdsa-sha2-nistp384', 'AAAA...=', 'rsync backup'],
     )
     # rubocop:enable Layout/LineLength