User's home directory is changed when $managehome => false and $HOME is in non-standard location

[bschonec]

Describe the Bug

Even when managehome => false, the non-root user's home directory will be changed if the user's home directory is in a non-standard location.

Expected Behavior

User's home directory shouldn't be changed when managehome=>false under any circumstances.

Steps to Reproduce

Steps to reproduce the behavior:

1. useradd -m -d /mnt/brian brian
Accounts::User{'brian':
  ensure => present,
  managehome => false,
}
Accounts::User[brian]/User[brian]/home: home changed '/mnt/brian' to '/home/brian' (corrective)

Environment

• Pppet 7.29.1
• Red Hat EL 8.8
• puppetlabs-accounts@main (08c59a4)

Additional Context

I think that the user defined type wrongly assumes that all account home directories will be under /home/${name}. There are some instances where this is not the case, such as the mongod user provide by mogodb-enterprise-server package.

One workaround is to provide the $home => /path/to/real/homedir to the user defined type but this is a bit clunky.