Review fixups

Author: hunner

REFERENCE.md

@@ -6696,11 +6696,11 @@ Default value: ``undef``
 
 ##### <a name="userdir"></a>`userdir`
 
-Data type: `Any`
+Data type: `Optional[String[1]]`
 
-Directory out of which per-user content is loaded. It may be any valid `UserDir` directive values.
+Path or directory name to be used as the UserDir.
 
-Default value: The value of `$path`
+Default value: ``undef``
 
 ##### <a name="disable_root"></a>`disable_root`
 

manifests/mod/userdir.pp

@@ -36,7 +36,7 @@
 class apache::mod::userdir (
   $home = undef,
   $dir = undef,
-  $userdir = undef,
+  Optional[String[1]] $userdir = undef,
   $disable_root = true,
   $apache_version = undef,
   $path = '/home/*/public_html',
@@ -63,10 +63,7 @@
     $_path = $path
   }
 
-  $_userdir = $userdir ? {
-    undef   => $_path,
-    default => $userdir,
-  }
+  $_userdir = pick($userdir, $_path)
 
   ::apache::mod { 'userdir': }