MODULES-10763 Do not report apt-get update as a change

Author: pillarsdotnet

manifests/update.pp

@@ -56,13 +56,22 @@
   } else {
     $_refresh = true
   }
+  $apt_update_successful = @("ASH"/$)
+    for try in \$(seq ${apt::_update['tries']} -1 1); do
+      timeout ${apt::_update['timeout']} ${apt::provider} update && exit 0
+      [ \$try -eq 1 ] && exit \$?
+      sleep 1
+    done
+    - ASH
   exec { 'apt_update':
-    command     => "${apt::provider} update",
+    command     => "echo ${apt::provider} update FAILED",
     loglevel    => $apt::_update['loglevel'],
     logoutput   => 'on_failure',
+    path        => '/bin:/usr/bin',
+    provider    => shell,
     refreshonly => $_refresh,
+    returns     => [-1], # This ensures a run-time failure.
     timeout     => $apt::_update['timeout'],
-    tries       => $apt::_update['tries'],
-    try_sleep   => 1,
+    unless      => $apt_update_successful,
   }
 }

spec/classes/apt_spec.rb

@@ -267,8 +267,7 @@
 
     it {
       is_expected.to contain_exec('apt_update').with(refreshonly: false,
-                                                     timeout: 1,
-                                                     tries: 3)
+                                                     timeout: 1)
     }
   end