(MODULES-11197) Rubocop fixes

Author: BobosilaVictor

.rubocop.yml

@@ -73,7 +73,7 @@ Style/SymbolArray:
   EnforcedStyle: brackets
 Style/SignalException:
   Enabled: false
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 Metrics/BlockNesting:
   Enabled: false
@@ -89,7 +89,7 @@ Style/NumericPredicate:
   Enabled: false
 Style/PredicateName:
   Enabled: false
-Style/VariableName:
+RSpec/VariableName:
   Enabled: false
 RSpec/MessageSpies:
   EnforcedStyle: receive

lib/puppet/provider/augeas/augeas.rb

@@ -95,17 +95,17 @@ def parse_commands(data)
         if f == :path
           start = sc.pos
           nbracket = 0
-          inSingleTick = false
-          inDoubleTick = false
+          in_single_tick = false
+          in_double_tick = false
           loop do
             sc.skip(%r{([^\]\[\s\\'"]|\\.)+})
             ch = sc.getch
             nbracket += 1 if ch == '['
             nbracket -= 1 if ch == ']'
-            inSingleTick = !inSingleTick if ch == "'"
-            inDoubleTick = !inDoubleTick if ch == '"'
+            in_single_tick = !in_single_tick if ch == "'"
+            in_double_tick = !in_double_tick if ch == '"'
             raise(_('unmatched [')) if nbracket < 0
-            break if (nbracket == 0 && !inSingleTick && !inDoubleTick && (ch =~ %r{\s})) || sc.eos?
+            break if (nbracket == 0 && !in_single_tick && !in_double_tick && (ch =~ %r{\s})) || sc.eos?
           end
           len = sc.pos - start
           len -= 1 unless sc.eos?
@@ -209,7 +209,7 @@ def close_augeas
     @aug = nil
   end
 
-  def is_numeric?(s)
+  def numeric?(s)
     case s
     when Integer
       true
@@ -236,8 +236,8 @@ def process_get(cmd_array)
     # check the value in augeas
     result = @aug.get(path) || ''
 
-    if ['<', '<=', '>=', '>'].include?(comparator) && is_numeric?(result) &&
-       is_numeric?(arg)
+    if ['<', '<=', '>=', '>'].include?(comparator) && numeric?(result) &&
+       numeric?(arg)
       resultf = result.to_f
       argf = arg.to_f
       return_value = resultf.send(comparator, argf)

lib/puppet/type/augeas.rb

@@ -129,7 +129,8 @@
   end
 
   newparam(:load_path) do
-    desc "Optional colon-separated list or array of directories; these directories are searched for schema definitions. The agent's `$libdir/augeas/lenses` path will always be added to support pluginsync."
+    desc "Optional colon-separated list or array of directories; these directories are searched for schema definitions.
+    The agent's `$libdir/augeas/lenses` path will always be added to support pluginsync."
     defaultto ''
   end
 

spec/unit/provider/augeas/augeas_spec.rb

@@ -475,19 +475,19 @@ def make_tmpname((prefix, suffix), n)
     end
     describe 'performing is_numeric checks (#22617)' do
       it 'returns false for nil' do
-        expect(provider.is_numeric?(nil)).to eq(false)
+        expect(provider.numeric?(nil)).to eq(false)
       end
       it 'returns true for Integers' do
-        expect(provider.is_numeric?(9)).to eq(true)
+        expect(provider.numeric?(9)).to eq(true)
       end
       it 'returns true for numbers in Strings' do
-        expect(provider.is_numeric?('9')).to eq(true)
+        expect(provider.numeric?('9')).to eq(true)
       end
       it 'returns false for non-number Strings' do
-        expect(provider.is_numeric?('x9')).to eq(false)
+        expect(provider.numeric?('x9')).to eq(false)
       end
       it 'returns false for other types' do
-        expect(provider.is_numeric?([true])).to eq(false)
+        expect(provider.numeric?([true])).to eq(false)
       end
     end