set preprocess_deferred to true by default

Author: LukasAud

spec/acceptance/deferred_spec.rb

@@ -17,23 +17,70 @@ def read_win_file_if_exists(path)
   { exists: exists, content: exists ? body : '' }
 end
 
+# ----- Always pass the flags to each puppet apply/idempotent_apply -----
+def puppet_flags
+  [
+    '--preprocess_deferred', 'true',
+    '--preferred_serialization_format', 'json',
+    '--color', 'false',
+    '--detailed-exitcodes'
+  ]
+end
+
+def apply_manifest_with_flags(manifest, opts = {})
+  apply_manifest(manifest, opts.merge(puppet_options: puppet_flags))
+end
+
+def idempotent_apply_with_flags(manifest, opts = {})
+  idempotent_apply(manifest, opts.merge(puppet_options: puppet_flags))
+end
+# ----------------------------------------------------------------------
+
+# Configure the agent once for this file (and assert) so the host is in a known state.
+RSpec.configure do |config|
+  config.before(:all) do
+    # Ensure Deferred values are preprocessed before providers run (Puppet 8 defaults can be lazy)
+    run_shell('puppet config set preprocess_deferred true --section agent')
+    # Avoid PSON quirks with Deferred serialization across the wire
+    run_shell('puppet config set preferred_serialization_format json --section agent')
+
+    # Assert settings for clear diagnostics in CI logs
+    pp  = run_shell('puppet config print preprocess_deferred --section agent').stdout.strip
+    fmt = run_shell('puppet config print preferred_serialization_format --section agent').stdout.strip
+    raise 'preprocess_deferred not true on agent!' unless pp.casecmp('true').zero?
+    raise 'preferred_serialization_format not json on agent!' unless fmt.casecmp('json').zero?
+
+    # Extra visibility
+    run_shell('puppet --version')
+    run_shell('puppet config print confdir')
+  end
+end
+
 describe 'deferred values with dsc_lite' do
   let(:control_manifest)         { read_fixture('01_file_deferred.pp') }
   let(:dsc_deferred_direct)      { read_fixture('02_dsc_deferred_direct.pp') }
-  let(:dsc_deferred_inline)      { read_fixture('02b_dsc_deferred_inline.pp') } # <— NEW
+  let(:dsc_deferred_inline)      { read_fixture('02b_dsc_deferred_inline.pp') } # — NEW
   let(:dsc_deferred_stringified) { read_fixture('03a_dsc_deferred_stringified.pp') }
   let(:dsc_deferred_bad_unwrap)  { read_fixture('03b_dsc_deferred_bad_unwrap.pp') }
 
+  # (Optional) Prove settings are active in this test context
+  it '00: confirms preprocess_deferred=true and JSON are active in this context' do
+    pp_out  = run_shell('puppet config print preprocess_deferred --section agent').stdout.strip
+    fmt_out = run_shell('puppet config print preferred_serialization_format --section agent').stdout.strip
+    expect(pp_out.downcase).to eq('true')
+    expect(fmt_out.downcase).to eq('json')
+  end
+
   it 'control (01): native file + Deferred resolves to hello-file' do
-    result = idempotent_apply(control_manifest)
+    result = idempotent_apply_with_flags(control_manifest)
     expect(result.exit_code).to eq(0)
     out = read_win_file_if_exists('C:/Temp/deferred_ok.txt')
     expect(out[:exists]).to be(true)
     expect(out[:content].strip).to eq('hello-file')
   end
 
   it '02: passing Deferred via variable to DSC resolves to hello-dsc (otherwise flag bug)' do
-    apply = apply_manifest(dsc_deferred_direct)
+    apply = apply_manifest_with_flags(dsc_deferred_direct)
     out   = read_win_file_if_exists('C:/Temp/from_dsc.txt')
     content = out[:content].strip
     if out[:exists] && content == 'hello-dsc'
@@ -47,7 +94,7 @@ def read_win_file_if_exists(path)
 
   # NEW 02b: inline Deferred on the DSC property (no variable intermediary)
   it '02b: passing Deferred inline to DSC resolves to hello-dsc-inline (otherwise flag bug)' do
-    apply = apply_manifest(dsc_deferred_inline)
+    apply = apply_manifest_with_flags(dsc_deferred_inline)
     out   = read_win_file_if_exists('C:/Temp/from_dsc_inline.txt')
     content = out[:content].strip
     if out[:exists] && content == 'hello-dsc-inline'
@@ -60,15 +107,15 @@ def read_win_file_if_exists(path)
   end
 
   it '03a: stringifying a Deferred writes the function form (reproduces customer report)' do
-    apply_manifest(dsc_deferred_stringified)
+    apply_manifest_with_flags(dsc_deferred_stringified)
     out = read_win_file_if_exists('C:/Temp/from_dsc_var_string.txt')
     expect(out[:exists]).to be(true)
     expect(out[:content]).to match(%r{Deferred\s*\(|Puppet::Pops::Types::Deferred}i)
     expect(out[:content]).not_to match(%r{\bhello-var\b})
   end
 
   it '03b: unwrap on a non‑Sensitive is a no‑op; also writes the function form' do
-    apply_manifest(dsc_deferred_bad_unwrap)
+    apply_manifest_with_flags(dsc_deferred_bad_unwrap)
     out   = read_win_file_if_exists('C:/Temp/from_dsc_var_bad_unwrap.txt')
     out   = read_win_file_if_exists('C:/Temp/from_dsc_var.txt') unless out[:exists]
     expect(out[:exists]).to be(true)