Correct Layout/EmptyLineAfterGuardClause

Author: LukasAud

.rubocop_todo.yml

@@ -1,18 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-05-28 10:29:32 UTC using RuboCop version 1.50.2.
+# on 2024-05-28 13:36:04 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'lib/puppet/provider/base_dsc_lite/powershell.rb'
-    - 'lib/puppet/type/dsc.rb'
-
 # Offense count: 27
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
@@ -78,17 +71,17 @@ Metrics/BlockLength:
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 133
+  Max: 111
 
 # Offense count: 4
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 31
 
-# Offense count: 11
+# Offense count: 10
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 54
+  Max: 40
 
 # Offense count: 4
 # Configuration parameters: AllowedMethods, AllowedPatterns.

lib/puppet/provider/base_dsc_lite/powershell.rb

@@ -78,6 +78,7 @@ def exists?
     Puppet.debug "Dsc Resource returned: #{output}"
     data = JSON.parse(output)
     raise(data['errormessage']) unless data['errormessage'].empty?
+
     exists = data['indesiredstate']
     Puppet.debug "Dsc Resource Exists?: #{exists}"
     Puppet.debug "dsc_ensure: #{resource[:dsc_ensure]}" if resource.parameters.key?(:dsc_ensure)

lib/puppet/type/dsc.rb

@@ -74,6 +74,7 @@ def change_to_s(currentvalue, newvalue)
     validate do |value|
       raise ArgumentError, "A non-empty #{name} must be specified." if value.nil? || value.empty?
       raise "#{name} should be a Hash or String" unless value.is_a?(Hash) || value.is_a?(String)
+
       if value.is_a?(Hash)
         valid_keys = ['name', 'version']
         raise(_('Must specify name and version if using ModuleSpecification')) unless (value.keys & valid_keys) == value.keys