Skip to content

Commit 7201c6d

Browse files
committed
(CAT-2453) Bump Rubocop versions in order to remove rexml
The version of rexml brought in by the current rubocop versions has a security vulnerability. Updating to these rubocop versions will remove their dependency entirely. Adding in plugins that where previously part of the default package, but have been split off since our previously used version.
1 parent 6fd80c1 commit 7201c6d

File tree

2 files changed

+24
-18
lines changed

2 files changed

+24
-18
lines changed

.rubocop.yml

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
---
2-
require:
3-
- rubocop-performance
4-
- rubocop-rspec
2+
plugins:
3+
- rubocop-rspec
4+
- rubocop-rspec_rails
5+
- rubocop-performance
6+
- rubocop-factory_bot
7+
- rubocop-capybara
58
AllCops:
69
NewCops: enable
710
DisplayCopNames: true
@@ -294,7 +297,7 @@ Performance/UriDefaultParser:
294297
Enabled: false
295298
RSpec/Be:
296299
Enabled: false
297-
RSpec/Capybara/FeatureMethods:
300+
RSpec/Dialect:
298301
Enabled: false
299302
RSpec/ContainExactly:
300303
Enabled: false
@@ -320,11 +323,11 @@ RSpec/ExpectChange:
320323
Enabled: false
321324
RSpec/ExpectInHook:
322325
Enabled: false
323-
RSpec/FactoryBot/AttributeDefinedStatically:
326+
FactoryBot/AttributeDefinedStatically:
324327
Enabled: false
325-
RSpec/FactoryBot/CreateList:
328+
FactoryBot/CreateList:
326329
Enabled: false
327-
RSpec/FactoryBot/FactoryClassName:
330+
FactoryBot/FactoryClassName:
328331
Enabled: false
329332
RSpec/HooksBeforeExamples:
330333
Enabled: false
@@ -600,27 +603,27 @@ RSpec/DuplicatedMetadata:
600603
Enabled: false
601604
RSpec/ExcessiveDocstringSpacing:
602605
Enabled: false
603-
RSpec/FactoryBot/ConsistentParenthesesStyle:
606+
FactoryBot/ConsistentParenthesesStyle:
604607
Enabled: false
605-
RSpec/FactoryBot/FactoryNameStyle:
608+
FactoryBot/FactoryNameStyle:
606609
Enabled: false
607-
RSpec/FactoryBot/SyntaxMethods:
610+
FactoryBot/SyntaxMethods:
608611
Enabled: false
609612
RSpec/IdenticalEqualityAssertion:
610613
Enabled: false
611614
RSpec/NoExpectationExample:
612615
Enabled: false
613616
RSpec/PendingWithoutReason:
614617
Enabled: false
615-
RSpec/Rails/AvoidSetupHook:
618+
RSpecRails/AvoidSetupHook:
616619
Enabled: false
617-
RSpec/Rails/HaveHttpStatus:
620+
RSpecRails/HaveHttpStatus:
618621
Enabled: false
619-
RSpec/Rails/InferredSpecType:
622+
RSpecRails/InferredSpecType:
620623
Enabled: false
621-
RSpec/Rails/MinitestAssertions:
624+
RSpecRails/MinitestAssertions:
622625
Enabled: false
623-
RSpec/Rails/TravelAround:
626+
RSpecRails/TravelAround:
624627
Enabled: false
625628
RSpec/RedundantAround:
626629
Enabled: false

Gemfile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,12 @@ group :development do
2727
gem "pry", '~> 0.10', require: false
2828
gem "simplecov-console", '~> 0.9', require: false
2929
gem "puppet-debugger", '~> 1.0', require: false
30-
gem "rubocop", '~> 1.50.0', require: false
31-
gem "rubocop-performance", '= 1.16.0', require: false
32-
gem "rubocop-rspec", '= 2.19.0', require: false
30+
gem "rubocop", '~> 1.73.0', require: false
31+
gem "rubocop-performance", '~> 1.24.0', require: false
32+
gem "rubocop-rspec", '~> 3.5.0', require: false
33+
gem 'rubocop-rspec_rails', '~> 2.31.0', require: false
34+
gem 'rubocop-factory_bot', '~> 2.27.0', require: false
35+
gem 'rubocop-capybara', '~> 2.22.0', require: false
3336
gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
3437
gem "github_changelog_generator", require: false
3538
gem "ruby-pwsh", require: false

0 commit comments

Comments
 (0)